Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl-File-Slurper: 0.010 -> 0.011 #32831

Closed
wants to merge 1 commit into from
Closed

perl-File-Slurper: 0.010 -> 0.011 #32831

wants to merge 1 commit into from

Conversation

pvgoran
Copy link
Contributor

@pvgoran pvgoran commented Dec 19, 2017

Fixes Leont/file-slurp-sane#5.

This is a troublesome bug that can cause hard-to-reproduce errors.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rycee rycee self-assigned this Dec 19, 2017
@rycee
Copy link
Member

rycee commented Dec 19, 2017

Rebased to master in 502ebb0. Thanks!

@rycee rycee closed this Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rycee rycee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pvgoran @rycee