tuntox: init at 0.0.8 #32823

fgaz · 2017-12-18T20:53:09Z

Motivation for this change

Add the tuntox package and a systemd service to set up a server with it. I may also add a tuntox client service in the future, so the server is under the tuntox.server namespace

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
- This causes the PreStart script to fail! Any idea why? Maybe I shouldn't create that directory that way, but I couldn't find alternatives.. or maybe /var isn't the right place?
```
tuntox.service: Failed at step NAMESPACE spawning /nix/store/wa0c5wzs92ngv7qbsbi0c3dvlxwk2fs0-unit-script/bin/tuntox-pre-start: No such file or directory
```
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

grahamc · 2017-12-19T12:09:35Z

@GrahamcOfBorg eval

orivej · 2017-12-24T01:39:32Z

This causes the PreStart script to fail!

What causes the PreStart script to fail? How can I reproduce it?

fgaz · 2017-12-24T08:34:51Z

@orivej useSandbox prevents the preStart script from creating/modifying/(accessing?) /var (edit: well, i'm not 100% sure that's the reason why it fails)

Just enable that option and set tuntox.server.enable = true and it should give that error in the journal (journalctl -b -u tuntox)

ryantm · 2018-09-08T22:18:54Z

nixos/modules/misc/ids.nix

@@ -306,6 +306,7 @@
      ceph = 288;
      duplicati = 289;
      monetdb = 290;
+      tuntox = 291;


Are you sure you need the user to be a specific ID? It usually isn't necessary since the system can assign user IDs.

ryantm · 2018-09-08T22:19:35Z

nixos/modules/services/networking/tuntox.nix

+      };
+
+      preStart = ''
+        mkdir -p ${persistentIdDirectory}


Instead of making the directory in a preStart you can do it in an activation script like in

nixpkgs/nixos/modules/services/web-apps/mattermost.nix

Line 165 in b43c4d8

system.activationScripts.mattermost = ''

ryantm · 2018-09-08T22:20:24Z

pkgs/tools/networking/tuntox/default.nix

+  src = fetchFromGitHub {
+    owner = "gjedeer";
+    repo = "tuntox";
+    rev = "${version}";


Can just be rev = version;.

ryantm · 2018-09-08T22:23:14Z

nixos/modules/services/networking/tuntox.nix

+{
+  options = {
+    services.tuntox.server = {
+      enable = mkOption {


Please use mkEnableOption here.

ryantm · 2018-09-08T22:24:46Z

nixos/modules/services/networking/tuntox.nix

+      secret = mkOption {
+        type = types.nullOr types.str;
+        default = null;
+        description = "Shared secret used for connection authentication";


It might be good to point out that this secret will be world readable when inserted in the Nix store. Can this optionally be done with a secretFile that is stored outside the nix store?

Ekleog · 2018-10-16T02:18:30Z

(triage) @fgaz Are you still willing to work on this?

fgaz · 2018-10-20T10:47:57Z

@Ekleog yes, but it'll have to wait a bit

aanderse · 2019-05-21T00:29:17Z

@fgaz do you need a hand with this or are you able to continue?

fgaz · 2019-06-28T12:14:25Z

@aanderse I just don't (and won't for another month) have much time to make and test those modifications. Maybe in the meantime I could split this into one pr for the package, which is quick and already reviewed, and keep this one for the module only.

aanderse

@fgaz Splitting this PR into 2 sounds like a good idea if you don't have the time but want to get the package in ASAP. If you're not in a rush, though, no worries because neither are we 😄

aanderse · 2019-07-05T01:51:06Z

pkgs/tools/networking/tuntox/default.nix

+{ stdenv, fetchFromGitHub, fetchpatch, pkgconfig, libtoxcore, libsodium, libevent }:
+
+stdenv.mkDerivation rec {
+  name = "tuntox-${version}";


Please replace with pname = "tuntox"; and then you can drop name as it will be implied.

aanderse · 2019-07-05T01:51:20Z

pkgs/tools/networking/tuntox/default.nix

+
+  src = fetchFromGitHub {
+    owner = "gjedeer";
+    repo = "tuntox";


repo = pname; is a common pattern.

aanderse · 2019-07-05T01:51:47Z

pkgs/tools/networking/tuntox/default.nix

+    license = licenses.gpl3;
+    platforms = platforms.linux;
+    maintainers = with maintainers; [ fgaz ];
+    homepage = https://github.com/gjedeer/tuntox;


Please quote.

ivan · 2019-09-06T15:53:49Z

For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated types.string, which emits a warning as of #66346. Before merging, please change this to another type, possibly:

types.str for a single string where merging does not make sense, or cannot work
types.lines for multi-line configuration or scripts where merging is possible
types.listOf types.str for a mergeable list of strings

stale · 2020-06-01T09:24:15Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

fgaz · 2020-06-07T10:14:41Z

Stale bot, I'll still finish this... someday

stale · 2021-06-03T20:34:44Z

I marked this as stale due to inactivity. → More info

willcohen · 2022-02-17T21:48:31Z

@fgaz Was looking at putting together a PR for tuntox and found this draft first. Are you still interested in finishing it? I'd also be happy to start a new PR based off of this WIP branch. I've never had to create a package that creates/enables a service there so I'm a little bit less certain about fine-tuning those details, but at the very least would like to see the binaries available!

fgaz · 2022-02-18T15:23:52Z

Wow, I totally forgot about this 😅

Thanks for pushing this forward @willcohen! I don't really want to finish the module for this right now, so let's go with your package!

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Dec 18, 2017

fgaz force-pushed the tuntox branch from d4221fe to 2bcbad8 Compare December 19, 2017 07:09

joachifm added the 2.status: merge conflict label Feb 20, 2018

fgaz force-pushed the tuntox branch from 2bcbad8 to 721b9b8 Compare May 2, 2018 16:54

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) labels May 2, 2018

tuntox: init at 0.0.8

683fd1d

fgaz force-pushed the tuntox branch from 721b9b8 to 683fd1d Compare May 2, 2018 17:04

GrahamcOfBorg added 8.has: package (new) and removed 2.status: merge conflict labels May 2, 2018

ryantm requested changes Sep 8, 2018

View reviewed changes

samueldr added the 2.status: merge conflict label Nov 11, 2018

aanderse requested changes Jul 5, 2019

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2020

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

fgaz marked this pull request as draft November 25, 2020 16:55

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 17, 2022

willcohen mentioned this pull request Feb 18, 2022

tuntox: init at 0.0.10 #160548

Merged

13 tasks

fgaz closed this Feb 18, 2022

fgaz deleted the tuntox branch June 16, 2022 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tuntox: init at 0.0.8 #32823

tuntox: init at 0.0.8 #32823

fgaz commented Dec 18, 2017 •

edited

grahamc commented Dec 19, 2017

orivej commented Dec 24, 2017

fgaz commented Dec 24, 2017 •

edited

ryantm Sep 8, 2018

ryantm Sep 8, 2018

ryantm Sep 8, 2018

ryantm Sep 8, 2018

ryantm Sep 8, 2018

Ekleog commented Oct 16, 2018

fgaz commented Oct 20, 2018

aanderse commented May 21, 2019

fgaz commented Jun 28, 2019

aanderse left a comment

aanderse Jul 5, 2019

aanderse Jul 5, 2019

aanderse Jul 5, 2019

ivan commented Sep 6, 2019

stale bot commented Jun 1, 2020

fgaz commented Jun 7, 2020

stale bot commented Jun 3, 2021

willcohen commented Feb 17, 2022

fgaz commented Feb 18, 2022

tuntox: init at 0.0.8 #32823

tuntox: init at 0.0.8 #32823

Conversation

fgaz commented Dec 18, 2017 • edited

Motivation for this change

Things done

grahamc commented Dec 19, 2017

orivej commented Dec 24, 2017

fgaz commented Dec 24, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ekleog commented Oct 16, 2018

fgaz commented Oct 20, 2018

aanderse commented May 21, 2019

fgaz commented Jun 28, 2019

aanderse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivan commented Sep 6, 2019

stale bot commented Jun 1, 2020

fgaz commented Jun 7, 2020

stale bot commented Jun 3, 2021

willcohen commented Feb 17, 2022

fgaz commented Feb 18, 2022

fgaz commented Dec 18, 2017 •

edited

fgaz commented Dec 24, 2017 •

edited