Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgtap: 0.97.0 -> 0.98.0, highlight: 3.40 -> 3.41 #32276

Merged
merged 2 commits into from Dec 4, 2017
Merged

pgtap: 0.97.0 -> 0.98.0, highlight: 3.40 -> 3.41 #32276

merged 2 commits into from Dec 4, 2017

Conversation

WilliButz
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (I ran the pgjwt test)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis merged commit 3130c11 into NixOS:master Dec 4, 2017
@adisbladis
Copy link
Member

Thanks!

While both of these commits are fine can you split it up into two PRs next time since the packages are not related?

@WilliButz WilliButz deleted the packageUpdates branch December 4, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @adisbladis @GrahamcOfBorg