Make less known wayland compositors usable #32285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @peterhoeg Thanks! |
|
Cc: @miltador as way-cooler maintainer. |
|
LGTM for |
FRidh
reviewed
Dec 4, 2017
| }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| let | ||
| callPackage = newScope self; |
There was a problem hiding this comment.
why not pass in callPackage instead?
ghost
changed the title
GrahamcOfBorg
added
10.rebuild-linux: 1-10
10.rebuild-darwin: 1-10
and removed
10.rebuild-linux: 0
10.rebuild-darwin: 0
labels
ghost
mentioned this pull request
ghost
changed the title
|
PR is finished. |
ghost
changed the title
zimbatm
reviewed
Dec 13, 2017
| st-wayland = callPackage ./st.nix { | ||
| conf = stConf; | ||
| patches = stPatches; | ||
| }; |
There was a problem hiding this comment.
why not add these to all-packages.nix?
ghost
mentioned this pull request
|
Is it going to be merged? |
added 5 commits
December 21, 2017 12:47
the development of orbment and velox got stuck their subprojects (bemenu, dmenu-wayland, st-wayland) don't work correctly outside of parent projects so hide them to not confuse people swc and wld libraries are unpopular and unlike wlc are not used by anything except velox
added 4 commits
December 21, 2017 17:41
|
Started nox-review on my build machine. If it passes I will merge. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
They are currently either broken or not usable out of box. This PR fixes that.
way-cooler:
via module
orbment:
velox:
must be launched via swc-launch Launching Velox michaelforney/velox#25
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)