Fix a mistake about exception handling in asynchronous execution of scan_partitioner. #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can_partitioner. In asynchronous execution, exceptions must be wrapped in hpx::future.
sithhell
reviewed
Dec 11, 2017
| return hpx::make_exceptional_future<R>(std::current_exception()); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you elaborate on why this has to be removed please?
There was a problem hiding this comment.
@sithhell This is fundamentally wrong.
f.has_exception() always returns false when the task is running.
And, even if f.has_exception() can return true, this code is still wrong because occurred exception must be wrapped into the future.
There was a problem hiding this comment.
thanks for the clarification. makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.