Baguette in bootstrap #2929
Merged
Baguette in bootstrap #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Kwpolska
reviewed
Dec 4, 2017
| <!-- fancy dates --> | ||
| <script> | ||
| moment.locale("${momentjs_locales[lang]}"); | ||
| fancydates(${date_fanciness}, ${js_date_format}); | ||
| </script> | ||
| <!-- end fancy dates --> | ||
| <%block name="extra_js"></%block> | ||
| <script>baguetteBox.run('a.reference', { |
There was a problem hiding this comment.
Why did we change the classes baguetteBox works with?
There was a problem hiding this comment.
That's copied from base theme. Probably both should be what was in bootstrap instead.
I'll take a look at it tomorrow.
There was a problem hiding this comment.
This seems to work in the demo cases. Since baguette is not JQuery based, I don't see a simple way to use that complex selector :-(
|
Sorry am sorta swamped. I'll take a look this week-ish.
…On Mon, Dec 11, 2017 at 2:23 PM Chris Warrick ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nikola/data/themes/bootstrap3/templates/base.tmpl
<#2929 (comment)>:
> <!-- fancy dates -->
<script>
moment.locale("${momentjs_locales[lang]}");
fancydates(${date_fanciness}, ${js_date_format});
</script>
<!-- end fancy dates -->
<%block name="extra_js"></%block>
+ <script>baguetteBox.run('a.reference', {
Ping?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2929 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAGK4m5v0P3By2I5qoLs7Iy21KZAnrJks5s_WUigaJpZM4Qz-_o>
.
|
|
Please backport the |
Kwpolska
approved these changes
Dec 26, 2017
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
Thanks for merging and reviewing @Kwpolska |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is backwards-incompatible since it's bound to break people's themes.