Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android-platform-tools: 26.0.0 -> 26.0.2 #32289

Merged
merged 1 commit into from Dec 9, 2017

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Dec 3, 2017

Motivation for this change

Upgrading to the latest adb and fastboot for newer devices.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Dec 3, 2017

λ nixpkgs →  ./result/bin/fastboot --version
fastboot version -4022467
Installed as /nix/store/cb27g8a8s0msgggin7pybpsk43bkl3xv-android-platform-tools-r26.0.2/platform-tools/fastboot

Tested that it and adb were able to detect and reboot my phone.

Don't have anything to test Darwin besides:

λ nixpkgs →  nix-prefetch-url https://dl.google.com/android/repository/platform-tools_r26.0.2-darwin.zip
path is '/nix/store/gq7dqx1vxx0m04vqqc45j2dsfw92p698-platform-tools_r26.0.2-darwin.zip'
0gy7apw9pmnnm41z6ywglw5va4ghmny4j57778may4q7ar751l56

@Mic92
Copy link
Member

Mic92 commented Dec 5, 2017

@GrahamcOfBorg build androidenv.platformTools

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

 extracting: platform-tools/systrace/catapult/telemetry/third_party/websocket-client/websocket/tests/__init__.py  
   creating: platform-tools/systrace/catapult/telemetry/third_party/websocket-client/websocket/tests/data/
  inflating: platform-tools/systrace/catapult/telemetry/third_party/websocket-client/websocket/tests/data/header01.txt  
  inflating: platform-tools/systrace/catapult/telemetry/third_party/websocket-client/websocket/tests/data/header02.txt  
  inflating: platform-tools/systrace/catapult/telemetry/third_party/websocket-client/websocket/tests/test_websocket.py  
  inflating: platform-tools/systrace/catapult/telemetry/update_docs  
  inflating: platform-tools/systrace/catapult/telemetry/validate_binary_dependencies  
  inflating: platform-tools/systrace/systrace.py  
  inflating: platform-tools/fastboot  
/nix/store/cb27g8a8s0msgggin7pybpsk43bkl3xv-android-platform-tools-r26.0.2

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

these derivations will be built:
  /nix/store/fbqhqv03xhyqk4g4p2kn9zb9ym3sb473-platform-tools_r26.0.2-darwin.zip.drv
  /nix/store/xm4pmwvgr2s1l9ya4zjgb4s2cc30lpd7-android-platform-tools-r26.0.2.drv
building '/nix/store/fbqhqv03xhyqk4g4p2kn9zb9ym3sb473-platform-tools_r26.0.2-darwin.zip.drv' on 'ssh://mac1'...
copying 1 paths...
copying path '/nix/store/gq7dqx1vxx0m04vqqc45j2dsfw92p698-platform-tools_r26.0.2-darwin.zip' from 'ssh://mac1'...
building '/nix/store/xm4pmwvgr2s1l9ya4zjgb4s2cc30lpd7-android-platform-tools-r26.0.2.drv' on 'ssh://mac1'...
copying 1 paths...
copying path '/nix/store/wcqwblwr5bjlx8zhikvqd3kvb8cggp4w-android-platform-tools-r26.0.2' from 'ssh://mac1'...
/nix/store/wcqwblwr5bjlx8zhikvqd3kvb8cggp4w-android-platform-tools-r26.0.2

@Mic92 Mic92 merged commit 61a177a into NixOS:master Dec 9, 2017
@bhipple bhipple deleted the feature/android-platform-tools-26.0.2 branch February 24, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants