Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abcMIDI: 2017.06.10 -> 2017.11.27 #32281

Closed
wants to merge 1 commit into from
Closed

Conversation

dotlambda
Copy link
Member

Motivation for this change

The github repo doesn't seem to be updated any longer.

I was also condering renaming the package to lowercase abcmidi because most distros do so:
https://repology.org/metapackage/abcmidi/versions
The only problem I see is that it wouldn't be updated if already installed, if I am correct.
What do you think?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

ping @rycee

@rycee
Copy link
Member

rycee commented Dec 5, 2017

Rebased to master in 601c895. Thanks!

About the renaming I think it would mean that people installing through nix-env -i would miss out. I'm not exactly certain how nix-env -u works, though, since I've always used the attribute name to install packages. Not sure if it is worth it if it is purely a cosmetic change.

@rycee rycee closed this Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants