dillinger: init at 2017-10-08 with module and minimal test #32275
Conversation
|
/cc @cillianderoiste :) |
WilliButz
force-pushed
the
add-dillinger
branch
from
a716543
to
4d25b66
Compare
| port = mkOption { | ||
| type = types.int; | ||
| default = 8080; | ||
| example = 2342; |
There was a problem hiding this comment.
I think a description and a default is sufficient in this case to understand what the port option is supposed to be :)
|
|
||
| user = mkOption { | ||
| type = types.nullOr types.str; | ||
| default = "nobody"; |
There was a problem hiding this comment.
how about adding a dillinger user (most of such services use a custom user)
|
@matthewbauer I just rebased this on the current master but dillinger is based on |
|
I think that as the README stated that Node v4+ should be fine (see https://github.com/joemccann/dillinger/tree/9581db83096a29948c7059bb421fd27e23f4f7f8#installation) @WilliButz besides the test have you confirmed the basic functionality of the software? (in this case it should be fine, between NodeJS 4 and 6 aren't too much breaking changes that could cause an issue for us) As this seems to be a NodeSource powered product (which uses NSolid, see https://nodesource.com/products/nsolid and I don't know anything about this ecosystem except what I just read) I'm not sure how easy it is to perform platform bumps or maintain compatibility among several platforms... |
Motivation for this change
Adds the markdown editor web-app dillinger
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)