New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Breaking change release note for bintools-wrapper #33196
doc: Breaking change release note for bintools-wrapper #33196
Conversation
@@ -95,6 +95,15 @@ following incompatible changes:</para> | |||
<link xlink:href="https://search.nix.gsc.io/?q=stateVersion">here</link>. | |||
</para> | |||
</listitem> | |||
<listitem> | |||
<warning>This belongs in Nixpkgs release notes, were we to have it</warning> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO to me to create this, or just remove the warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation: For another different one, I want to hyperlink a nixpkgs manual section, which is only readily done from within the nixpkgs manual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've intentionally restricted nixpkgs/NixOS release notes to NixOS as there is hardly any code which could not be added to both and we don't technically have releases for nixpkgs,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same argument would seem to work for merging the two manuals :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd agree, simply by looking at my behaviour of grepping through both every time I look for something. But that discussion should not start here, but rather on the mailing list or an RFC. :)
@@ -95,6 +95,15 @@ following incompatible changes:</para> | |||
<link xlink:href="https://search.nix.gsc.io/?q=stateVersion">here</link>. | |||
</para> | |||
</listitem> | |||
<listitem> | |||
<warning>This belongs in Nixpkgs release notes, were we to have it</warning> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've intentionally restricted nixpkgs/NixOS release notes to NixOS as there is hardly any code which could not be added to both and we don't technically have releases for nixpkgs,
5b9dc1f
to
d67e092
Compare
Motivation for this change
#29396 needs an announcement.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)