Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Breaking change release note for bintools-wrapper #33196

Merged
merged 1 commit into from Dec 31, 2017

Conversation

Ericson2314
Copy link
Member

Motivation for this change

#29396 needs an announcement.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -95,6 +95,15 @@ following incompatible changes:</para>
<link xlink:href="https://search.nix.gsc.io/?q=stateVersion">here</link>.
</para>
</listitem>
<listitem>
<warning>This belongs in Nixpkgs release notes, were we to have it</warning>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO to me to create this, or just remove the warning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation: For another different one, I want to hyperlink a nixpkgs manual section, which is only readily done from within the nixpkgs manual.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've intentionally restricted nixpkgs/NixOS release notes to NixOS as there is hardly any code which could not be added to both and we don't technically have releases for nixpkgs,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same argument would seem to work for merging the two manuals :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd agree, simply by looking at my behaviour of grepping through both every time I look for something. But that discussion should not start here, but rather on the mailing list or an RFC. :)

@Ericson2314 Ericson2314 added this to Needed by the big PR---nice to move pick off pieces of it and move here, rebasing the big PR on top in Cross compilation Dec 30, 2017
@Ericson2314 Ericson2314 moved this from Needed by the big PR---nice to move pick off pieces of it and move here, rebasing the big PR on top to Needed for binutils-wrapper in Cross compilation Dec 30, 2017
@Ericson2314 Ericson2314 moved this from Needed for binutils-wrapper to Needed by the big PR---nice to move pick off pieces of it and move here, rebasing the big PR on top in Cross compilation Dec 30, 2017
@Ericson2314 Ericson2314 mentioned this pull request Dec 30, 2017
13 tasks
@@ -95,6 +95,15 @@ following incompatible changes:</para>
<link xlink:href="https://search.nix.gsc.io/?q=stateVersion">here</link>.
</para>
</listitem>
<listitem>
<warning>This belongs in Nixpkgs release notes, were we to have it</warning>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've intentionally restricted nixpkgs/NixOS release notes to NixOS as there is hardly any code which could not be added to both and we don't technically have releases for nixpkgs,

@Ericson2314 Ericson2314 merged commit fa9f0e5 into NixOS:master Dec 31, 2017
@Ericson2314 Ericson2314 deleted the bintools-release-note branch December 31, 2017 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Cross compilation
Needed by the big PR---nice to move p...
Development

Successfully merging this pull request may close these issues.

None yet

4 participants