Patch/delocalisedbonds #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplayed as '>CH' in the delocalised rings.
… Some small rings will use a circle/donut/life buoy in future but this does not handle the general case (e.g. porphyrin).
egonw
reviewed
Dec 29, 2017
| @@ -220,13 +220,35 @@ public void alwaysDisplayCharges() { | |||
|
|
|||
| a1.setPoint2d(new Point2d(0, 0)); | |||
| a2.setPoint2d(new Point2d(0.5, -0.5)); | |||
| a2.setPoint2d(new Point2d(1, 0)); | |||
| a3.setPoint2d(new Point2d(1, 0)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better depiction of aromatic bonds that have a undefined bond order. Kekule structures are preferred by IUPAC, but when a structure has no valid kekule form it is useful to depict them as delocalised. I will add pretty rendering for small rings (e.g. use a circle) in future but the most generally applicable method is to show a dashed bond to the side - we can't put circles in the macrocycle of porphyrin for example.
Kekule rendering:
When not kekulize or the 'force delocalised rendering' is set: