pelican: Disable pandoc support for now #33175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.7.1 is not compatible with the current (more recent) pandoc version. Since pandoc support is optional in pelican, we can ship it without pandoc support until a fix will be applied upstream. Kept a note in the buildInputs so that the improvement opportunity can be spotted again on future updates of pelican.
|
How did it even work? During build-time it can find pandoc but afterwards it won't because it will no longer have any reference to it. |
|
Actually that's a valid point, my assumption is that it did not work. I did not try it out myself though, I am not using the import feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.7.1 is not compatible with the current (more recent) pandoc version.
Since pandoc support is optional in pelican, we can ship it without pandoc
support until a fix will be applied upstream.
Kept a note in the buildInputs so that the improvement opportunity can be
spotted again on future updates of pelican.
Motivation for this change
Noticed that the build of pelican is failing since a few days: https://hydra.nixos.org/job/nixpkgs/trunk/python36Packages.pelican.x86_64-linux
Got hit by it myself a few hours ago.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)