Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pythonix: init at 0.1.0 #33174

Merged
merged 1 commit into from Dec 29, 2017
Merged

python3Packages.pythonix: init at 0.1.0 #33174

merged 1 commit into from Dec 29, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 29, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner December 29, 2017 16:42
@Mic92 Mic92 merged commit 805e259 into NixOS:master Dec 29, 2017
FRidh
FRidh reviewed Dec 29, 2017
View reviewed changes
pkgs/development/python-modules/pythonix/default.nix

assert isPy3k;

stdenv.mkDerivation rec {
Copy link
Member

@FRidh FRidh Dec 29, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark it as a Python module. It can be marked as a module with toPythonModule. This is needed e.g. for python.buildEnv.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b81de99

@Mic92 Mic92 deleted the pythonix branch December 30, 2017 23:56
Mic92 added a commit that referenced this pull request Dec 30, 2017
@Mic92
pythonix: mark it as a python module
b81de99 
This was mentioned by @FRidh in #33174 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @FRidh @GrahamcOfBorg