New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leocad: 17.02 -> 17.07 #33193
leocad: 17.02 -> 17.07 #33193
Conversation
@GrahamcOfBorg build leocad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure for system: x86_64-darwin
source root is source
patching sources
configuring
sh: g++: command not found
qmake4Hook: enabled parallel building
building
build flags: -j1 -l1 SHELL=/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash
make: *** No rule to make target '/private/tmp/nix-build-leocad-17.07.drv-0/source/library.bin', needed by 'build/release/LeoCAD.app/Contents/Resources/library.bin'. Stop.
builder for ‘/nix/store/lpcpvpl5h9bfsamn4lbw2i7p7fwsh1xy-leocad-17.07.drv’ failed with exit code 2
error: build of ‘/nix/store/lpcpvpl5h9bfsamn4lbw2i7p7fwsh1xy-leocad-17.07.drv’ failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: x86_64-linux
install -m 644 -p /tmp/nix-build-leocad-17.07.drv-0/source/resources/application-vnd.leocad.svg /nix/store/bgz5blp5qrl766zhr7d2614sjx4r5syd-leocad-17.07/share/icons/hicolor/scalable/mimetypes/
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bgz5blp5qrl766zhr7d2614sjx4r5syd-leocad-17.07
shrinking /nix/store/bgz5blp5qrl766zhr7d2614sjx4r5syd-leocad-17.07/bin/leocad
gzipping man pages under /nix/store/bgz5blp5qrl766zhr7d2614sjx4r5syd-leocad-17.07/share/man/
stripping (with flags -S) in /nix/store/bgz5blp5qrl766zhr7d2614sjx4r5syd-leocad-17.07/bin
patching script interpreter paths in /nix/store/bgz5blp5qrl766zhr7d2614sjx4r5syd-leocad-17.07
checking for references to /tmp/nix-build-leocad-17.07.drv-0 in /nix/store/bgz5blp5qrl766zhr7d2614sjx4r5syd-leocad-17.07...
/nix/store/bgz5blp5qrl766zhr7d2614sjx4r5syd-leocad-17.07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: aarch64-linux
install -m 644 -p /build/source/resources/application-vnd.leocad.svg /nix/store/g67zkby6mmqd6sivsxk373jj0xj8yxk5-leocad-17.07/share/icons/hicolor/scalable/mimetypes/
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g67zkby6mmqd6sivsxk373jj0xj8yxk5-leocad-17.07
shrinking /nix/store/g67zkby6mmqd6sivsxk373jj0xj8yxk5-leocad-17.07/bin/leocad
gzipping man pages under /nix/store/g67zkby6mmqd6sivsxk373jj0xj8yxk5-leocad-17.07/share/man/
stripping (with flags -S) in /nix/store/g67zkby6mmqd6sivsxk373jj0xj8yxk5-leocad-17.07/bin
patching script interpreter paths in /nix/store/g67zkby6mmqd6sivsxk373jj0xj8yxk5-leocad-17.07
checking for references to /build in /nix/store/g67zkby6mmqd6sivsxk373jj0xj8yxk5-leocad-17.07...
/nix/store/g67zkby6mmqd6sivsxk373jj0xj8yxk5-leocad-17.07
I think this is reasonable, given that it's just a version bump, but patching Makefile to refer to |
I'll fix that myself. Thank you! |
It seems to be more complicated than that, qmake file has set platform to build for ( |
:( Just to understand how :( this is, did leocad previously build/work on Darwin? FWIW we might want to move this to qt5, since it appears to support that and general Nix trend is to prefer Qt5 when both are available. |
It never did. I think the problem starts here: https://github.com/leozide/leocad/blob/41c342f46f4e445caa8cf65f3151c51ed401782a/leocad.spec#L181 GCC is also hardcoded in few other places. Yeah, Qt5 would be much better! |
@yegortimoshenko I think .spec is unrelated, only used for RPM builds? The So maybe qt5 will solve all our problems? hopeful face |
Oh, you are right, that's probably what fails. But then when I tried to change it to Perhaps! But having something to build on Darwin is not critical. |
Motivation for this change
Release notes: https://github.com/leozide/leocad/releases/tag/v17.07
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)