Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radare2: 2.1.0 -> 2.2.0, parallel #33194

Merged
merged 2 commits into from Dec 30, 2017
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 30, 2017

Motivation for this change

Lots of improvements/fixes: https://github.com/radare/radare2/releases/tag/2.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member

@GrahamcOfBorg build radare2

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘radare2-2.2.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/development/tools/analysis/radare2/default.nix:49 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

shrinking /nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0/lib/libr_bin.so.2.2.0
shrinking /nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0/lib/libr_asm.so.2.2.0
shrinking /nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0/lib/libr_anal.so.2.2.0
gzipping man pages under /nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0/share/man/
stripping (with flags -S) in /nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0/lib  /nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0/bin
patching script interpreter paths in /nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0
/nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/cvbdn77044rj012x7xfv1dj2dv9zqkcd-bash-4.4-p12/bin/sh"
/nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/cvbdn77044rj012x7xfv1dj2dv9zqkcd-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0...
/nix/store/lqwgf3zsh1mbbfbwfa206ixn4xz3fpac-radare2-2.2.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0/lib/libr_core.so.2.2.0
shrinking /nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0/lib/libr_crypto.so.2.2.0
shrinking /nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0/lib/libr_egg.so.2.2.0
gzipping man pages under /nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0/share/man/
stripping (with flags -S) in /nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0/lib  /nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0/bin 
patching script interpreter paths in /nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0
/nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/sh"
/nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-radare2-2.2.0.drv-0 in /nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0...
/nix/store/ar62369yzpm6qy492bdyxaghz4r736jx-radare2-2.2.0

@lukateras lukateras merged commit 6f3a431 into NixOS:master Dec 30, 2017
@dtzWill
Copy link
Member Author

dtzWill commented Dec 30, 2017

Wonderful, thanks!

@dtzWill dtzWill deleted the update/radare2-2.2.0 branch December 30, 2017 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants