Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo: 0.29 -> 0.30.2 #33181

Merged
merged 1 commit into from Dec 29, 2017
Merged

hugo: 0.29 -> 0.30.2 #33181

merged 1 commit into from Dec 29, 2017

Conversation

kierdavis
Copy link
Contributor

I've only updated the one dependency github.com/alecthomas/chroma that required it. Would it be better if all dependencies were brought to their latest versions (as would be done automatically when installing it via go get)?

Motivation for this change

I require hugo >= 0.30 to build the sourcebots docs locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc maintainer @schneefux

@kierdavis
hugo: 0.29 -> 0.30.2
901fa26 
Also requires updating the github.com/alecthomas/chroma dependency.
@adisbladis
Copy link
Member

@GrahamcOfBorg build hugo

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 29, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

patching script interpreter paths in /nix/store/r0dpccxxcclcx4g6fffw32g25gkgpnca-hugo-0.30.2-bin
checking for references to /tmp/nix-build-hugo-0.30.2.drv-0 in /nix/store/r0dpccxxcclcx4g6fffw32g25gkgpnca-hugo-0.30.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/x2ckfpcnkpbnk5jdnlvkrfwbqff99myf-hugo-0.30.2
patching script interpreter paths in /nix/store/x2ckfpcnkpbnk5jdnlvkrfwbqff99myf-hugo-0.30.2
/nix/store/x2ckfpcnkpbnk5jdnlvkrfwbqff99myf-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/bench.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/x2ckfpcnkpbnk5jdnlvkrfwbqff99myf-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/benchSite.sh: interpreter directive changed from "/bin/bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/x2ckfpcnkpbnk5jdnlvkrfwbqff99myf-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/pull-docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/x2ckfpcnkpbnk5jdnlvkrfwbqff99myf-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/docs/pull-theme.sh: interpreter directive changed from "/bin/bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-hugo-0.30.2.drv-0 in /nix/store/x2ckfpcnkpbnk5jdnlvkrfwbqff99myf-hugo-0.30.2...
/nix/store/r0dpccxxcclcx4g6fffw32g25gkgpnca-hugo-0.30.2-bin

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 29, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/private/tmp/nix-build-hugo-0.30.2.drv-0
post-installation fixup
stripping (with flags -S) in /nix/store/jwjirlb3wlqip403al5af3i6mikq48g1-hugo-0.30.2-bin/bin 
patching script interpreter paths in /nix/store/jwjirlb3wlqip403al5af3i6mikq48g1-hugo-0.30.2-bin
patching script interpreter paths in /nix/store/3xmlw8kh98bxfhans7q1a1i15ny7czz3-hugo-0.30.2
/nix/store/3xmlw8kh98bxfhans7q1a1i15ny7czz3-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/bench.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/3xmlw8kh98bxfhans7q1a1i15ny7czz3-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/benchSite.sh: interpreter directive changed from "/bin/bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/3xmlw8kh98bxfhans7q1a1i15ny7czz3-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/pull-docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/3xmlw8kh98bxfhans7q1a1i15ny7czz3-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/docs/pull-theme.sh: interpreter directive changed from "/bin/bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/jwjirlb3wlqip403al5af3i6mikq48g1-hugo-0.30.2-bin

@adisbladis adisbladis merged commit 99b4959 into NixOS:master Dec 29, 2017
GrahamcOfBorg
GrahamcOfBorg reviewed Dec 29, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

patching script interpreter paths in /nix/store/vj68r1xcvs28fb1b07gl858skqw592bc-hugo-0.30.2-bin
checking for references to /build in /nix/store/vj68r1xcvs28fb1b07gl858skqw592bc-hugo-0.30.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/hwkm9d1cpzmc0kmkadbq5zfr9pn25kc2-hugo-0.30.2
patching script interpreter paths in /nix/store/hwkm9d1cpzmc0kmkadbq5zfr9pn25kc2-hugo-0.30.2
/nix/store/hwkm9d1cpzmc0kmkadbq5zfr9pn25kc2-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/bench.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cvbdn77044rj012x7xfv1dj2dv9zqkcd-bash-4.4-p12/bin/bash"
/nix/store/hwkm9d1cpzmc0kmkadbq5zfr9pn25kc2-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/benchSite.sh: interpreter directive changed from "/bin/bash" to "/nix/store/cvbdn77044rj012x7xfv1dj2dv9zqkcd-bash-4.4-p12/bin/bash"
/nix/store/hwkm9d1cpzmc0kmkadbq5zfr9pn25kc2-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/docs/pull-theme.sh: interpreter directive changed from "/bin/bash" to "/nix/store/cvbdn77044rj012x7xfv1dj2dv9zqkcd-bash-4.4-p12/bin/bash"
/nix/store/hwkm9d1cpzmc0kmkadbq5zfr9pn25kc2-hugo-0.30.2/share/go/src/github.com/gohugoio/hugo/pull-docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/cvbdn77044rj012x7xfv1dj2dv9zqkcd-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/hwkm9d1cpzmc0kmkadbq5zfr9pn25kc2-hugo-0.30.2...
/nix/store/vj68r1xcvs28fb1b07gl858skqw592bc-hugo-0.30.2-bin

@adisbladis
Copy link
Member

adisbladis commented Dec 29, 2017 •
edited

It would be nice to get the deps up to date as well but it is not required.
Fyi it looks like this package was mostly automatically generated with https://github.com/kamilchm/go2nix so that should be fairly easy.

@kierdavis kierdavis deleted the hugo-0.30.2 branch December 29, 2017 23:20
@kierdavis kierdavis mentioned this pull request Dec 29, 2017
Merged
8 tasks
@kierdavis
Copy link
Contributor Author

Thanks. I've followed this up in #33192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kierdavis @adisbladis @GrahamcOfBorg