Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libresolv: fix library version #33179

Merged
merged 1 commit into from Dec 30, 2017
Merged

libresolv: fix library version #33179

merged 1 commit into from Dec 30, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 29, 2017 •
edited

Motivation for this change

The rust binary builds (and possibly other things) don't like that our version of libresolv doesn't have any version.
.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Dec 29, 2017
@LnL7 LnL7 changed the base branch from master to staging December 29, 2017 19:05
@LnL7 LnL7 merged commit d2b02d6 into NixOS:staging Dec 30, 2017
@LnL7 LnL7 deleted the darwin-libresolv branch December 30, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @GrahamcOfBorg