dash-to-panel: init at v11 #33177
dash-to-panel: init at v11 #33177
Conversation
| sha256 = "1bfcnrhw6w8yrz8sw520kwwshmplkg4awpvz07kg4d73m6zn4mw2"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ |
There was a problem hiding this comment.
This should likely not be nativeBuildInputs but buildInputs.
This is related to cross compilation of nixpkgs.
nativeBuildInputs are for dependencies needed during the build process (think compilers, build tools etc) and buildInputs are for things that end up getting used on the target platform (think shared libraries and such needed at runtime).
There was a problem hiding this comment.
To be honest I just copied pretty much the whole of dash-to-dock, maybe that will also require an update then? Nonetheless, will fix it :)
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "gnome-shell-dash-to-panel-${version}"; | ||
| version = "v11"; |
There was a problem hiding this comment.
Minor thing: It's common practice in nix not to use a "v" before version numbers. You should move that to the rev attribute passed to fetchFromGithub as such:
rev = "v${version}";.
Motivation for this change
A useful gnome shell extension, likely used by many and as chrome-gnome-shell doesn't work I couldn't install it in an easier way.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)