Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: Rename jws_private_key to openid_connect_signing_key #33197

Merged
merged 1 commit into from Jan 6, 2018
Merged

gitlab: Rename jws_private_key to openid_connect_signing_key #33197

merged 1 commit into from Jan 6, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Dec 30, 2017

Motivation for this change

Otherwise gitlab fails to start due to missing secret.

See
gitlabhq/omnibus-gitlab@24d56df

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej merged commit b249907 into NixOS:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @orivej @GrahamcOfBorg