Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: A few misc cross changes from #26805 #33185

Merged
merged 4 commits into from Dec 29, 2017
Merged

treewide: A few misc cross changes from #26805 #33185

merged 4 commits into from Dec 29, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Dec 29, 2017 •
edited

Motivation for this change

These are already tested. They should be uncontroversial, and in the Qt cases I talked them over with @ttuegel (this is an unintersting subset of what we talked about in the thread).

Trying to lesson the diff before #26805 is (hopefully very soon!) merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

bgamari and others added 4 commits December 29, 2017 17:18
@bgamari @Ericson2314
gawk: Enable cross-compilation
6f4cfe0
@bgamari @Ericson2314
diffutils: Enable cross-compilation
946c1b2
@Ericson2314
libelf: Fix cross compilation
e73d805 
There is an upstream bug where it is assumed that if host != build, host
doesn't support shared libraries. We override that overly conservative
check. See
http://lists.uclibc.org/pipermail/uclibc-cvs/2005-August/019383.html

Also clean up some comments.
@Ericson2314
kmime, colord-kde: ki18n should be *run*-time dependency
5dea877 
It is gettext-based, but is a library for run time, relying on the
normal gettext tools at build time.
@Ericson2314 Ericson2314 removed the request for review from ttuegel December 29, 2017 22:29
@Ericson2314 Ericson2314 merged commit b1dcc6c into NixOS:staging Dec 29, 2017
@Ericson2314 Ericson2314 deleted the cross-simple branch December 29, 2017 22:30
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Dec 29, 2017
@Ericson2314 Ericson2314 added this to Needed by the big PR---nice to move pick off pieces of it and move here, rebasing the big PR on top in Cross compilation Dec 29, 2017
@ttuegel ttuegel requested review from ttuegel and removed request for ttuegel December 30, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
No open projects
Cross compilation
Needed by the big PR---nice to move p...
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @GrahamcOfBorg @bgamari