Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r2-cutter: init at 1.1(.0), radare2 qt gui #33198

Merged
merged 1 commit into from Feb 18, 2018
Merged

r2-cutter: init at 1.1(.0), radare2 qt gui #33198

merged 1 commit into from Feb 18, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 30, 2017

Naming "r2-cutter" since "cutter" already exists,
but AFAIK this naming is not used anywhere else currently.

Motivation for this change

Updated version of #32345 for 1.1 release (and new radare2 in #33194)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill mentioned this pull request Dec 30, 2017
Closed
8 tasks
@lukateras lukateras self-requested a review December 30, 2017 15:56
@dtzWill
Copy link
Member Author

dtzWill commented Jan 3, 2018

(Soft ping 😇)

orivej
orivej reviewed Jan 19, 2018
View reviewed changes
pkgs/development/tools/analysis/cutter/default.nix Outdated
let tag = "1.1"; in
stdenv.mkDerivation rec {
name = "r2-cutter-${version}";
version = "${tag}.0";
Copy link
Contributor

@orivej orivej Jan 19, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you add .0 to the version number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, don't remember. Something worked better with "full" version specification, maybe some tool I use. If it seems odd I'll change it :).

pkgs/top-level/all-packages.nix Outdated
@@ -7707,6 +7707,7 @@ with pkgs;
rubyBindings = config.radare.rubyBindings or false;
luaBindings = config.radare.luaBindings or false;
};
r2-cutter = qt5.callPackage ../development/tools/analysis/cutter { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use libsForQt5.

AUR names it radare2-cutter (https://aur.archlinux.org/packages/radare2-cutter/), would you like that name? I'd also rename the directory to radare2-cutter for consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye aye.

@dtzWill
radare2-cutter: init at 1.1
bcf81b8 
radare2 qt gui, using name used in AUR
since 'cutter' already exists.
@dtzWill
Copy link
Member Author

dtzWill commented Jan 21, 2018

Thanks for review @orivej! Updated to address your comments.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build radare2-cutter

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘radare2-2.2.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/analysis/radare2/default.nix:49 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ii13qd8qp0fgpb8yn6lqwz4z10dy6mk2-radare2-cutter-1.1
shrinking /nix/store/ii13qd8qp0fgpb8yn6lqwz4z10dy6mk2-radare2-cutter-1.1/bin/cutter
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ii13qd8qp0fgpb8yn6lqwz4z10dy6mk2-radare2-cutter-1.1/bin
patching script interpreter paths in /nix/store/ii13qd8qp0fgpb8yn6lqwz4z10dy6mk2-radare2-cutter-1.1
checking for references to /build in /nix/store/ii13qd8qp0fgpb8yn6lqwz4z10dy6mk2-radare2-cutter-1.1...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/ii13qd8qp0fgpb8yn6lqwz4z10dy6mk2-radare2-cutter-1.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash: dialogs/AboutDialog.ui: Permission denied
dialogs/CommentsDialog.ui -o ui_CommentsDialog.h
/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash: dialogs/preferences/AsmOptionsWidget.ui: Permission denied
make: *** [Makefile:939: ui_AboutDialog.h] Error 126
make: *** Waiting for unfinished jobs....
make: *** [Makefile:942: ui_AsmOptionsWidget.h] Error 126
/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash: dialogs/CommentsDialog.ui: Permission denied
make: *** [Makefile:945: ui_CommentsDialog.h] Error 126
builder for '/nix/store/iapyd557zc5hg2pdhicq896lvz6z89sl-radare2-cutter-1.1.drv' failed with exit code 2
error: build of '/nix/store/iapyd557zc5hg2pdhicq896lvz6z89sl-radare2-cutter-1.1.drv' failed

@joachifm
Copy link
Contributor

@dtzWill any idea about the aarch64 failure? If not, perhaps constrain the platform list to only x86 linux?

@dtzWill
Copy link
Member Author

dtzWill commented Feb 18, 2018

Looks to be another instance of NixOS/aarch64-build-box#17, although this is less clear than other cases.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 18, 2018

(FWIW: 1.2 is out, but has a few bugs so waiting until 1.3 or whatever is next)

@joachifm joachifm merged commit b4b8f4e into NixOS:master Feb 18, 2018
@dtzWill dtzWill mentioned this pull request Mar 3, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej left review comments

@lukateras lukateras Awaiting requested review from lukateras

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @joachifm @GrahamcOfBorg @orivej