Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: waterfox-bin: init at 56.0.1 #33184

Closed
wants to merge 1 commit into from
Closed

WIP: waterfox-bin: init at 56.0.1 #33184

wants to merge 1 commit into from

Conversation

notpushkin
Copy link

@notpushkin notpushkin commented Dec 29, 2017 •
edited

Motivation for this change

Requested at BrowserWorks/Waterfox#297

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" N/A
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This is my first Nix package, so if I'm missing something or doing something wrong, please point me at it :) Thanks!

UPD: please don't merge yet! Things currently broken:

  • Open / save dialogs crash the app, stating “No GSettings schemas are installed on the system” in stderr
  • The desktop entry isn't copied to profile

@notpushkin notpushkin mentioned this pull request Dec 29, 2017
Closed
@notpushkin notpushkin changed the title waterfox-bin: init at 56.0.1 WIP: waterfox-bin: init at 56.0.1 Dec 30, 2017
@lukateras
Copy link
Member

lukateras commented Dec 30, 2017 •
edited

Why patchelf and not from source? This would be hard(er) to maintain.

@notpushkin
Copy link
Author

@yegortimoshenko I definitely consider building from source too, thanks! I'm not yet familiar with the mozbuild process but it doesn't seem too hard. My problem right now is that I only have a laptop and it might not be powerful enough to build it adequate time (I'll give it a try today though!)

@Chiiruno
Copy link
Contributor

Any updates?

@TerkiKerel
Copy link

Any updates? :(

@Shados
Copy link
Member

Shados commented May 7, 2018

FWIW, I've taken a first pass at writing a package for building it from source, based on the existing firefox packages and Arch's waterfox PKGBUILD. I've been happily using it for the last week or so, but it needs some cleaning up I think, which I'm not sure I'll be able to get around to soon.

Likely it would be possible to have both firefox and waterfox packages based on a common expression, although probably it isn't worthwhile...

@Chiiruno
Copy link
Contributor

Chiiruno commented Oct 1, 2019

Any plans to update?

@notpushkin
Copy link
Author

I'm not actively using NixOS anymore, sorry :( @Shados feel free to take over if you're up to it!

@Shados
Copy link
Member

Shados commented Oct 2, 2019

I have some expressions for building both waterfox 56 and the 68 alpha from source here. They could be cleaner, especially if firefox-common were exposed in pkgs in nixpkgs, but they work. I'm not interested in upstreaming them into nixpkgs personally, as I have doubts on whether waterfox has any real future. As things stand, I don't know of any usably modern browsers that I like, orz.

@Valodim
Copy link
Contributor

Valodim commented May 3, 2020

closing as stale (see last two comments), if someone wants to pick this up please open a new PR

@Valodim Valodim closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: work-in-progress 8.has: package (new) 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@notpushkin @lukateras @Chiiruno @TerkiKerel @Shados @Valodim @joachifm @infinisil @Janik-Haag