Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.mediaplayer: init at 3.5 #33180

Merged
merged 1 commit into from Dec 30, 2017
Merged

gnomeExtensions.mediaplayer: init at 3.5 #33180

merged 1 commit into from Dec 30, 2017

Conversation

tiramiseb
Copy link
Contributor

Motivation for this change

Allow to install the mediaplayer GNOME Shell extension from a package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 30, 2017

Does not build with sandboxing enabled without the following:

  postPatch = ''
    chmod +x meson_post_install.py
    patchShebangs meson_post_install.py
  '';

@jtojnar jtojnar mentioned this pull request Dec 30, 2017
Open
@jtojnar
Copy link
Contributor

jtojnar commented Dec 30, 2017

If you also add rm build to postPatch, you can get rid of the manual ninja and meson invocations.

@jtojnar jtojnar added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) labels Dec 30, 2017
@tiramiseb
Copy link
Contributor Author

Thanks for your comments!
Obviously, it is cleaner this way. I had a hard time understanding the magic behind the derivations yesterday 😅

Sorry for the last commit message which does not fit the contribution rules; I fixed the conflict directly in the github interface...

@jtojnar jtojnar merged commit 9db8e22 into NixOS:master Dec 30, 2017
@jtojnar
Copy link
Contributor

jtojnar commented Dec 30, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiramiseb @jtojnar @GrahamcOfBorg @Janik-Haag