Ignore build warnings round 2 #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous attempt at ignoring build warnings (#3079) in the tuple test was actually no good. While it was the
tuple.hppheader generating the warnings, it was included before that transitively byhpx_init.hpp. I've instead put the ignores around all hpx headers now, with the risk of silencing future warnings which might be unrelated to the current warnings (but with the benefit of still ignoring the current warnings ifhpx_init.hppno longer would depend ontuple.hpp).Sorry for the noise.
This also adds another explicit base class initialization to get rid of a warning.