Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix array#sample with random #5419

Merged
merged 1 commit into from Dec 20, 2017
Merged

fix array#sample with random #5419

merged 1 commit into from Dec 20, 2017

Conversation

c910335
Copy link
Contributor

@c910335 c910335 commented Dec 20, 2017

Someone forgot to pass random.

ysbaddaden
ysbaddaden approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@RX14 RX14 merged commit 72e3460 into crystal-lang:master Dec 20, 2017
@RX14 RX14 modified the milestones: Next, 0.24.1 Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:crypto topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c910335 @ysbaddaden @RX14