google-cloud-speech: init at 0.30.0 #32890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Dec 20, 2017
| }; | ||
|
|
||
| propagatedBuildInputs = [ google_auth protobuf googleapis_common_protos requests grpcio ]; | ||
| buildInputs = [ setuptools mock pytest ]; |
|
|
||
| meta = { | ||
| description = "This library is not meant to stand-alone. Instead it defines common helpers used by all Google API clients."; | ||
| license = "apache"; |
There was a problem hiding this comment.
which specifically? Use lib.licences
| meta = { | ||
| description = "This library is not meant to stand-alone. Instead it defines common helpers used by all Google API clients."; | ||
| license = "apache"; | ||
| }; |
| meta = { | ||
| description = "This library is not meant to stand-alone. Instead it defines common helpers used by all Google API clients."; | ||
| license = "apache"; | ||
| }; |
| , google_auth, protobuf, googleapis_common_protos, requests, grpcio, setuptools, mock, pytest }: | ||
|
|
||
| buildPythonPackage rec { | ||
| name = "google-api-core-${version}"; |
There was a problem hiding this comment.
pname = "google-api-core";
version = "0.1.2";
drop name
|
|
||
| buildPythonPackage rec { | ||
| name = "google-auth-${version}"; | ||
| version = "1.2.1"; |
| sha256 = "041qpwlvpawggasvbfpkx39mkg4dgvivj831x7kinidayrf46w3i"; | ||
| }; | ||
|
|
||
| buildInputs = [ pytest mock oauth2client flask requests urllib3 pytest-localserver ]; |
|
|
||
| meta = { | ||
| description = "This library simplifies using Google’s various server-to-server authentication mechanisms to access Google APIs."; | ||
| license = "apache"; |
|
Also, a commit per expression is needed. |
vanschelven
force-pushed
the
google-cloud-speech
branch
from
4c7de61
to
3a180b0
Compare
|
@FRidh anything I can do to get this PR accepted? I've implemented the changes you requested. I'd rather have it merged now that it still has no conflicts with master. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Google Cloud Speech API enables developers to convert audio to text;
The provided package is the Python client.
Things done
pkgs/development/python-modules/google_cloud_speech/default.nix is the actual goal of the present commit; the other packages are required dependencies.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)