Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixpkgs/manual: fix build with new pandoc #32895

Merged
merged 1 commit into from Dec 20, 2017
Merged

nixpkgs/manual: fix build with new pandoc #32895

merged 1 commit into from Dec 20, 2017

Conversation

sopvop
Copy link
Contributor

@sopvop sopvop commented Dec 20, 2017 •
edited

Motivation for this change

Building manual fails with and error because pandoc now handles --smart option differently.
Also it seems pandoc now inserts <xmlns:...> stuff by itself is some cases, which breaks xmllint.

Things done

Updated flags for new pandoc.
Don't insert xmlns attributes where it is not needed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej merged commit b1e23d8 into NixOS:master Dec 20, 2017
@orivej
Copy link
Contributor

orivej commented Dec 20, 2017

That's great, thank you!

vcunat referenced this pull request Mar 2, 2020
@vcunat
nixpkgs manual: fix build after pandoc(?) update
83015ff 
I din't try to pinpoint the exact commit, but we started getting:
> The extension smart is not supported for docbook
Reading pandoc docs, I can't see what use to us "smart" could be
when writing the in-between docbook (to be converted to html).
https://pandoc.org/MANUAL.html#extension-smart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sopvop @orivej @GrahamcOfBorg @Janik-Haag