Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

j: 701_b -> 806 #32208

Merged
merged 1 commit into from Dec 1, 2017
Merged

j: 701_b -> 806 #32208

merged 1 commit into from Dec 1, 2017

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Nov 30, 2017 •
edited

Motivation for this change

j was way behind, at least 3 years. This fixes that and updates the build script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" (Forgot this step, but I don't believe that there are any packages that depend on j)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm merged commit 6ccf561 into NixOS:master Dec 1, 2017
@orivej
Copy link
Contributor

orivej commented Dec 2, 2017 •
edited

/usr/bin/env is not available in the sandbox (https://hydra.nixos.org/build/65198033), fixed in 7b1489e. Are you sure you have tested using sandboxing?

@Synthetica9
Copy link
Member Author

@orivej: I did nix-shell -I nixpkgs=/home/synthetica/devel/nixpkgs/ -I "nix.useSandbox=true" -p j, which in didn't work (20/20 hindsight), but also didn't give an error. What is the correct way to do this, for future reference?

@orivej
Copy link
Contributor

orivej commented Dec 2, 2017

The -I option just extends Nix search path, so -I nix.useSandbox=true will not enable the sandbox. If nix-info --sandbox says sandbox: yes, you can build in the sandbox with nix-build /home/synthetica/devel/nixpkgs -A j.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Synthetica9 @orivej @joachifm @GrahamcOfBorg @Janik-Haag