Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention GNOME-related stuff in changelog #32200

Merged
merged 2 commits into from Feb 14, 2018
Merged

Mention GNOME-related stuff in changelog #32200

merged 2 commits into from Feb 14, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 30, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat vcunat added this to the 18.03 milestone Nov 30, 2017
@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 17, 2017 •
edited

I’ve got a feeling I wanted to mention one more thing but I cannot recall what it was.

@jtojnar jtojnar merged commit 8e6ea91 into NixOS:master Feb 14, 2018
@jtojnar jtojnar deleted the gnome-changelog branch February 14, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @vcunat @GrahamcOfBorg