Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.quandl: 3.0.0 -> 3.2.1 #32202

Merged
merged 10 commits into from Dec 14, 2017
Merged

pythonPackages.quandl: 3.0.0 -> 3.2.1 #32202

merged 10 commits into from Dec 14, 2017

Conversation

1pakch
Copy link
Contributor

@1pakch 1pakch commented Nov 30, 2017

Motivation for this change
  1. Update the package to the current version (3.2.1 from 3.0.0)
  2. Add Python 3.5 and 3.6 support in addition to 2.7
  3. Enable build tests
Naming

The old package used was accessible via Quandl. I suggest

  1. to usequandl (lowercase) as default name since it is consistent with
  2. to make the new package accessible as Quandl as well.
Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change
  • Tested compilation of all pkgs that depend on this change
  • Tested the library
  • Fits [CONTRIBUTING.md]

@1pakch 1pakch requested a review from FRidh as a code owner November 30, 2017 13:03
Mic92
Mic92 reviewed Dec 1, 2017
View reviewed changes
pkgs/top-level/python-packages.nix Outdated

quandl = callPackage ../development/python-modules/quandl { };
# alias for an older package which did not support Python 3
Quandl = callPackage ../development/python-modules/quandl { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you keep ordering in this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do this to keep merge conflicts low.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Not all packages in python-packages.nix appear in alphabetical order so I thought it's not important.

@joachifm joachifm merged commit fbc452c into NixOS:master Dec 14, 2017
@1pakch 1pakch deleted the python-quandl branch April 28, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@1pakch @Mic92 @joachifm @GrahamcOfBorg