Add papis: 0.5.0 #32760

matthiasbeyer · 2017-12-17T14:34:42Z

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Need help here. It does not find configparser though the dependency is clearly in scope.

FRidh · 2017-12-17T19:02:48Z

pkgs/top-level/python-packages.nix

@@ -6252,6 +6254,10 @@ in {

  paperwork-backend = callPackage ../applications/office/paperwork/backend.nix { };

+  papis = callPackage ../applications/office/papis { };


This is not correct. If its a Python library then it should be called from here but the expression should be in pkgs/development/python-modules

But it is not a library?

Then you should also add an entry to all-packages.nix i.e, papis = python3.pkgs.papis

Then it should have an entry in all-packages.nix, but it should not be called via python-packages.nix.

Moved to all-packages.nix.

FRidh · 2017-12-17T19:02:53Z

pkgs/applications/office/papis/default.nix

@@ -0,0 +1,41 @@
+{ lib, fetchFromGitHub, python3Packages, pkgs }:


don't pass in pkgs

FRidh · 2017-12-17T19:03:39Z

pkgs/development/python-modules/arxiv2bib/default.nix

+buildPythonPackage rec {
+  pname = "arxiv2bib";
+  version = "1.0.8";
+  name = "${pname}-${version}";


Don't set name. Its not required anymore with buildPython*

FRidh · 2017-12-17T19:03:48Z

pkgs/development/python-modules/pylibgen/default.nix

+python3Packages.buildPythonPackage rec {
+  pname = "pylibgen";
+  version = "1.3.0";
+  name = "${pname}-${version}";


FRidh · 2017-12-17T19:03:58Z

pkgs/development/python-modules/papis-python-rofi/default.nix

+buildPythonPackage rec {
+  pname = "papis-python-rofi";
+  version = "1.0.1";
+  name = "${pname}-${version}";


FRidh · 2017-12-17T19:05:51Z

pkgs/development/python-modules/pyparser/default.nix

+
+let
+  # pyparser only builds with parse == 1.6.5
+  parse = buildPythonPackage rec {


No "private" packages in python-packages.nix because that can cause collisions.

So how to do this then? We need this specific version (we have a more recent version in nixpkgs, but we need an older one for the papis package (see comment)).

FRidh · 2017-12-17T19:06:46Z

pkgs/development/python-modules/arxiv2bib/default.nix

+    description = "Get arXiv.org metadata in BibTeX format";
+    license     = stdenv.lib.licenses.bsd;
+    maintainers = with stdenv.lib.maintainers; [ matthiasbeyer ];
+    platforms   = stdenv.lib.platforms.unix;


why only .unix?

FRidh · 2017-12-17T19:06:53Z

pkgs/development/python-modules/papis-python-rofi/default.nix

+    description = "Create simple GUIs using the Rofi application";
+    license     = stdenv.lib.licenses.mit;
+    maintainers = with stdenv.lib.maintainers; [ matthiasbeyer ];
+    platforms   = stdenv.lib.platforms.unix;


why only .unix?

FRidh · 2017-12-17T19:07:02Z

pkgs/development/python-modules/pylibgen/default.nix

+    description = "Programmatic Python interface for Library Genesis";
+    license     = stdenv.lib.licenses.mit;
+    maintainers = with stdenv.lib.maintainers; [ matthiasbeyer ];
+    platforms   = stdenv.lib.platforms.unix;


why only .unix?

FRidh · 2017-12-17T19:07:19Z

pkgs/development/python-modules/pyparser/default.nix

+    description = "A collection of classes to make it easier to parse text data in a pythonic way";
+    license     = stdenv.lib.licenses.mit;
+    maintainers = with stdenv.lib.maintainers; [ matthiasbeyer ];
+    platforms   = stdenv.lib.platforms.unix;


why only .unix?

orivej · 2017-12-17T19:52:22Z

BTW it was surprising to discover that in Nixpkgs lib.platforms.unix == lib.platforms.all. As a matter of style, I think all is preferred in all cases.

FRidh · 2018-01-08T16:56:27Z

pkgs/applications/office/papis/default.nix

@@ -0,0 +1,41 @@
+{ lib, fetchFromGitHub, python3Packages }:
+
+python3Packages.buildPythonPackage rec {


Why not buildPythonApplication then?

matthiasbeyer · 2018-01-09T10:08:03Z

Still fails because of builder for ‘/nix/store/gs64w0j7yfyw80zb1q8hvyn1b775p9am-python2.7-pylibgen-1.3.0.drv’ failed with exit code 1.

FRidh · 2018-01-09T11:55:42Z

pkgs/applications/office/papis/default.nix

+
+python3Packages.buildPythonApplication rec {
+  name = "papis-${version}";
+  version = "v0.5.0";


without the v

FRidh · 2018-01-09T11:56:02Z

pkgs/applications/office/papis/default.nix

+  src = fetchFromGitHub {
+    owner = "alejandrogallo";
+    repo = "papis";
+    rev = version;


this could be e.g. rev = "v${version}";

FRidh · 2018-01-09T11:56:25Z

pkgs/development/python-modules/pylibgen/default.nix

+pythonPackages.buildPythonPackage rec {
+  pname = "pylibgen";
+  version = "1.3.0";
+  name = "${pname}-${version}";


FRidh · 2018-01-09T11:56:35Z

pkgs/development/python-modules/pylibgen/default.nix

@@ -0,0 +1,25 @@
+{ pythonPackages, fetchPypi , python , stdenv }:


no pythonPackages in python-modules. This applies to other expressions as well.

FRidh · 2018-01-09T11:57:28Z

pkgs/development/python-modules/pyparser/default.nix

+
+let
+  # pyparser only builds with parse == 1.6.5
+  parse = buildPythonPackage rec {


We can't have "private" packages inside python-packages.nix as that could cause collisions.

So what do you suggest?

matthiasbeyer · 2018-01-09T13:03:04Z

pkgs/development/python-modules/pyparser/default.nix

+
+let
+  # pyparser only builds with parse == 1.6.5
+  parse = buildPythonPackage rec {


As mentioned by @FRidh, this should not be. I don't know how to do this, though.

Btw I also don't understand why github marks the other comments on this diff as outdated, I did not change this part of the diff in my fixup commits!

I don't mind helping out, but this needs a bit more effort. Mainly, check and verify that your contribution is according to the (Python) contributing guidelines because it gets very tiring having to note certain parts have not been checked.

FRidh · 2018-02-03T08:46:26Z

pkgs/development/python-modules/pyparser/default.nix

+
+let
+  # pyparser only builds with parse == 1.6.5
+  parse = buildPythonPackage rec {


I don't mind helping out, but this needs a bit more effort. Mainly, check and verify that your contribution is according to the (Python) contributing guidelines because it gets very tiring having to note certain parts have not been checked.

FRidh · 2018-02-03T08:46:54Z

pkgs/development/python-modules/arxiv2bib/default.nix

@@ -0,0 +1,19 @@
+{ buildPythonPackage , fetchPypi , python , stdenv }:
+
+buildPythonPackage rec {


Tests are not run. I noticed no tests are included in this archive.

FRidh · 2018-02-03T08:47:25Z

pkgs/top-level/python-packages.nix

@@ -13506,13 +13512,13 @@ in {


  vobject = buildPythonPackage rec {
-    version = "0.9.3";
+    version = "0.9.5";


I've pushed this commit to master (even though this expression should be moved).

nico202 · 2018-02-14T08:54:54Z

Hi, I just realized this issue was open, #34761 solves it, can be closed

matthiasbeyer requested a review from FRidh as a code owner December 17, 2017 14:34

FRidh requested changes Dec 17, 2017

View reviewed changes

FRidh added the 6.topic: python label Dec 17, 2017

matthiasbeyer added 12 commits January 8, 2018 17:07

pythonPackages.vobject: 0.9.3 -> 0.9.5

2d7891b

pythonPackages.arxiv2bib: init at 1.0.8

c83316e

pythonPackages.pylibgen: init at 1.3.0

bb0256b

pythonPackages.pyparser: init at 1.0

3a5a602

pythonPackages.papis-python-rofi: init at 1.0.1

b2960d2

[WIP] papis: init at 0.5.0

1442480

fixup! [WIP] papis: init at 0.5.0

6d813e3

fixup! pythonPackages.arxiv2bib: init at 1.0.8

de3e85a

fixup! pythonPackages.papis-python-rofi: init at 1.0.1

4286adb

fixup! pythonPackages.pylibgen: init at 1.3.0

4155533

fixup! pythonPackages.pylibgen: init at 1.3.0

0be75c1

fixup! pythonPackages.pyparser: init at 1.0

60974cb

matthiasbeyer force-pushed the add-papis branch from 511df6e to 60974cb Compare January 8, 2018 16:15

FRidh reviewed Jan 8, 2018

View reviewed changes

fixup! [WIP] papis: init at 0.5.0

1192fd7

FRidh requested changes Jan 9, 2018

View reviewed changes

matthiasbeyer added 4 commits January 9, 2018 13:58

fixup! [WIP] papis: init at 0.5.0

4a99351

fixup! pythonPackages.pylibgen: init at 1.3.0

5a1c2d7

fixup! pythonPackages.pyparser: init at 1.0

79c358b

fixup! pythonPackages.pylibgen: init at 1.3.0

05ff561

matthiasbeyer commented Jan 9, 2018

View reviewed changes

FRidh requested changes Feb 3, 2018

View reviewed changes

FRidh added the 2.status: work-in-progress label Feb 3, 2018

matthiasbeyer closed this Feb 14, 2018

matthiasbeyer deleted the add-papis branch February 14, 2018 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add papis: 0.5.0 #32760

Add papis: 0.5.0 #32760

matthiasbeyer commented Dec 17, 2017

FRidh Dec 17, 2017

matthiasbeyer Jan 8, 2018

globin Jan 8, 2018

FRidh Jan 8, 2018

matthiasbeyer Jan 9, 2018

FRidh Dec 17, 2017

FRidh Dec 17, 2017

FRidh Dec 17, 2017

FRidh Dec 17, 2017

FRidh Dec 17, 2017

matthiasbeyer Jan 8, 2018

FRidh Dec 17, 2017

FRidh Dec 17, 2017

FRidh Dec 17, 2017

FRidh Dec 17, 2017

orivej commented Dec 17, 2017

FRidh Jan 8, 2018

matthiasbeyer commented Jan 9, 2018

FRidh Jan 9, 2018

FRidh Jan 9, 2018

FRidh Jan 9, 2018

FRidh Jan 9, 2018

FRidh Jan 9, 2018

matthiasbeyer Jan 9, 2018

matthiasbeyer Jan 9, 2018

matthiasbeyer Jan 9, 2018

FRidh Feb 3, 2018

FRidh Feb 3, 2018

FRidh Feb 3, 2018

FRidh Feb 3, 2018

nico202 commented Feb 14, 2018

		@@ -6252,6 +6254,10 @@ in {

		paperwork-backend = callPackage ../applications/office/paperwork/backend.nix { };

		papis = callPackage ../applications/office/papis { };

		@@ -0,0 +1,41 @@
		{ lib, fetchFromGitHub, python3Packages, pkgs }:

		@@ -0,0 +1,41 @@
		{ lib, fetchFromGitHub, python3Packages }:

		python3Packages.buildPythonPackage rec {

		@@ -0,0 +1,25 @@
		{ pythonPackages, fetchPypi , python , stdenv }:

		@@ -0,0 +1,19 @@
		{ buildPythonPackage , fetchPypi , python , stdenv }:

		buildPythonPackage rec {

Add papis: 0.5.0 #32760

Add papis: 0.5.0 #32760

Conversation

matthiasbeyer commented Dec 17, 2017

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orivej commented Dec 17, 2017

Choose a reason for hiding this comment

matthiasbeyer commented Jan 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nico202 commented Feb 14, 2018