Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpcap: increase maximum snapshot length for dbus #32739

Merged
merged 1 commit into from Dec 16, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 16, 2017

Motivation for this change

DBus packet size can be bigger than the size allowed by libpcap, which breaks applications like bustle.

The issue was fixed upstream so we are backporting the commits.

wjt/bustle#4

Things done

I confirmed that this fixed the bustle issue.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

DBus packet size can be bigger than the size allowed by libpcap,
which breaks applications like bustle.

The issue was fixed upstream so we are backporting the commits.

wjt/bustle#4
@orivej orivej merged commit ee03ae2 into NixOS:master Dec 16, 2017
@jtojnar jtojnar deleted the libpcap-nolimit branch December 29, 2017 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants