Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joker: 0.8.6 -> 0.8.7 #32748

Merged
merged 1 commit into from Dec 17, 2017
Merged

joker: 0.8.6 -> 0.8.7 #32748

merged 1 commit into from Dec 17, 2017

Conversation

andrestylianos
Copy link
Member

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@disassembler
Copy link
Member

@GrahamcOfBorg build joker

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 17, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking RPATHs of ELF executables and libraries in /nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7
patching script interpreter paths in /nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7
/nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7/share/go/src/github.com/candid82/joker/flag-tests.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/sxwh6a4v8xdlvg4jf3vl2jh9l5760hsc-bash-4.4-p12/bin/bash"
/nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7/share/go/src/github.com/candid82/joker/build-all.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/sxwh6a4v8xdlvg4jf3vl2jh9l5760hsc-bash-4.4-p12/bin/bash"
/nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7/share/go/src/github.com/candid82/joker/test-linter.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/sxwh6a4v8xdlvg4jf3vl2jh9l5760hsc-bash-4.4-p12/bin/bash"
/nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7/share/go/src/github.com/candid82/joker/linter-tests.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/sxwh6a4v8xdlvg4jf3vl2jh9l5760hsc-bash-4.4-p12/bin/bash"
/nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7/share/go/src/github.com/candid82/joker/std/generate-std.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/sxwh6a4v8xdlvg4jf3vl2jh9l5760hsc-bash-4.4-p12/bin/bash"
/nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7/share/go/src/github.com/candid82/joker/run.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/sxwh6a4v8xdlvg4jf3vl2jh9l5760hsc-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-joker-0.8.7.drv-0 in /nix/store/jxy7s01x35w72gl6dlcbz76rvnyycy08-joker-0.8.7...
/nix/store/0dq7zcggxsh305pc1y10j0g6lq4m0m75-joker-0.8.7-bin

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 17, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

stripping (with flags -S) in /nix/store/5k1lypd069b1bscih30d2i4r4aj9001x-joker-0.8.7-bin/bin
patching script interpreter paths in /nix/store/5k1lypd069b1bscih30d2i4r4aj9001x-joker-0.8.7-bin
patching script interpreter paths in /nix/store/cr4nm2n0p8qai80m4653by51gcsqba2a-joker-0.8.7
/nix/store/cr4nm2n0p8qai80m4653by51gcsqba2a-joker-0.8.7/share/go/src/github.com/candid82/joker/build-all.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/593crms1j53ac0sa873x42km2zl7i5mh-bash-4.4-p12/bin/bash"
/nix/store/cr4nm2n0p8qai80m4653by51gcsqba2a-joker-0.8.7/share/go/src/github.com/candid82/joker/flag-tests.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/593crms1j53ac0sa873x42km2zl7i5mh-bash-4.4-p12/bin/bash"
/nix/store/cr4nm2n0p8qai80m4653by51gcsqba2a-joker-0.8.7/share/go/src/github.com/candid82/joker/linter-tests.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/593crms1j53ac0sa873x42km2zl7i5mh-bash-4.4-p12/bin/bash"
/nix/store/cr4nm2n0p8qai80m4653by51gcsqba2a-joker-0.8.7/share/go/src/github.com/candid82/joker/run.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/593crms1j53ac0sa873x42km2zl7i5mh-bash-4.4-p12/bin/bash"
/nix/store/cr4nm2n0p8qai80m4653by51gcsqba2a-joker-0.8.7/share/go/src/github.com/candid82/joker/std/generate-std.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/593crms1j53ac0sa873x42km2zl7i5mh-bash-4.4-p12/bin/bash"
/nix/store/cr4nm2n0p8qai80m4653by51gcsqba2a-joker-0.8.7/share/go/src/github.com/candid82/joker/test-linter.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/593crms1j53ac0sa873x42km2zl7i5mh-bash-4.4-p12/bin/bash"
/nix/store/5k1lypd069b1bscih30d2i4r4aj9001x-joker-0.8.7-bin

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 17, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

shrinking RPATHs of ELF executables and libraries in /nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7
patching script interpreter paths in /nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7
/nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7/share/go/src/github.com/candid82/joker/test-linter.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1zs9yh57pzsbrf2g51q1qzaxkrmnm7vk-bash-4.4-p12/bin/bash"
/nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7/share/go/src/github.com/candid82/joker/std/generate-std.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1zs9yh57pzsbrf2g51q1qzaxkrmnm7vk-bash-4.4-p12/bin/bash"
/nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7/share/go/src/github.com/candid82/joker/run.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1zs9yh57pzsbrf2g51q1qzaxkrmnm7vk-bash-4.4-p12/bin/bash"
/nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7/share/go/src/github.com/candid82/joker/linter-tests.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1zs9yh57pzsbrf2g51q1qzaxkrmnm7vk-bash-4.4-p12/bin/bash"
/nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7/share/go/src/github.com/candid82/joker/flag-tests.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1zs9yh57pzsbrf2g51q1qzaxkrmnm7vk-bash-4.4-p12/bin/bash"
/nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7/share/go/src/github.com/candid82/joker/build-all.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1zs9yh57pzsbrf2g51q1qzaxkrmnm7vk-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/zcj4b32b5sdn7vwj9y8dc8k9prdjplyd-joker-0.8.7...
/nix/store/sjm4p5jxgfn1h31yha2zvcbkbcjy54qx-joker-0.8.7-bin

@disassembler disassembler merged commit a76896e into NixOS:master Dec 17, 2017
@disassembler
Copy link
Member

merged! thanks for the update!

@andrestylianos andrestylianos deleted the joker branch April 3, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrestylianos @disassembler @GrahamcOfBorg