Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elementary-xfce-icon-theme: init at 2017-11-28 #32745

Merged
merged 1 commit into from Dec 18, 2017
Merged

elementary-xfce-icon-theme: init at 2017-11-28 #32745

merged 1 commit into from Dec 18, 2017

Conversation

davidak
Copy link
Member

@davidak davidak commented Dec 16, 2017 •
edited

Motivation for this change

I want to use it with Xfce.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member Author

davidak commented Dec 16, 2017

It builds but the icons are not visible.

It has the issue described in #18536.

@grahamc
Copy link
Member

grahamc commented Dec 17, 2017

@GrahamcOfBorg eval

@davidak
Copy link
Member Author

davidak commented Dec 17, 2017

I rebuilt the whole system what took 8 hours. Now some icons are visible, but still the error with missing icon cache.

screenshot_2017-12-17_06-24-19

@yellowgh0st
Copy link
Contributor

yellowgh0st commented Dec 17, 2017 •
edited

It's problem just with XFCE environment not relative to icon theme.
This is what I use.

 environment.variables = {
    GDK_PIXBUF_MODULE_FILE = "${pkgs.librsvg.out}/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache";
 };

@davidak
Copy link
Member Author

davidak commented Dec 17, 2017

@yellowgh0st it works that way.

I also made it a little more robust with the version numbers.

  environment.variables = {
     GDK_PIXBUF_MODULE_FILE = "$(ls ${pkgs.librsvg.out}/lib/gdk-pixbuf-*/*/loaders.cache)";
  };

screenshot_2017-12-17_23-39-03

@davidak davidak changed the title [WIP] elementary-xfce-icon-theme: init at 2017-11-28 elementary-xfce-icon-theme: init at 2017-11-28 Dec 17, 2017
lukateras
lukateras approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot_2017-12-18_03-38-28

@davidak davidak mentioned this pull request Dec 18, 2017
Merged
8 tasks
@orivej orivej merged commit 964008d into NixOS:master Dec 18, 2017
@davidak davidak deleted the elementary-xfce branch December 18, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@davidak @grahamc @yellowgh0st @lukateras @orivej @GrahamcOfBorg