gitea: 1.2.3 -> 1.3.2 #32742
gitea: 1.2.3 -> 1.3.2 #32742
Conversation
| + StaticRootPath = sec.Key("STATIC_ROOT_PATH").MustString("@data@") | ||
| AppDataPath = sec.Key("APP_DATA_PATH").MustString("data") | ||
| AppDataPath = sec.Key("APP_DATA_PATH").MustString(path.Join(AppWorkPath, "data")) |
There was a problem hiding this comment.
Should not this instance of AppWorkPath be replaced by @data@ too?
There was a problem hiding this comment.
Is APP_DATA_PATH supposed to be writeable? In that case it should be not in the nix store.
There was a problem hiding this comment.
I haven't had a chance to test this yet, but the original understanding behind putting the data in the store is the nixos service copies that data from the nix store -> the state directory before starting the service. I believe this was related to the locales and static files that needed to be in the state directory.
There was a problem hiding this comment.
sorry @orivej I didn't see your comment. I'll submit a PR to adjust that as well.
There was a problem hiding this comment.
Err wait, nevermind. AppDataPath we don't want in the store. The whole point for replacing StaticRootPath was because it writes those files in the build there. This is correct as-is unless someone disagrees.
|
Nice catch. I missed it when I was patching the new file. Will update soon
and check the file more thoroughly.
…On December 16, 2017 at 13:04:44, Orivej Desh ***@***.***) wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/applications/version-management/gitea/static-root-path.patch
<#32742 (comment)>:
> + StaticRootPath = ***@***.***@")
- AppDataPath = sec.Key("APP_DATA_PATH").MustString("data")
+ AppDataPath = sec.Key("APP_DATA_PATH").MustString(path.Join(AppWorkPath, "data"))
Should not this instance of AppWorkPath be replaced by @DaTa@ too?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32742 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUdp5G6Tdtn0zDL5dcltk-Zqse9Yd2Yks5tBDBsgaJpZM4REZ02>
.
|
|
@GrahamcOfBorg eval |
|
@GrahamcOfBorg build gitea |
There was a problem hiding this comment.
Success for system: x86_64-darwin
can't load package: package code.gitea.io/gitea/scripts: build constraints exclude all Go files in /private/tmp/nix-build-gitea-1.3.2.drv-0/go/src/code.gitea.io/gitea/scripts
installing
/private/tmp/nix-build-gitea-1.3.2.drv-0/go /private/tmp/nix-build-gitea-1.3.2.drv-0
/private/tmp/nix-build-gitea-1.3.2.drv-0
post-installation fixup
stripping (with flags -S) in /nix/store/0z0fic8lwxz8bx4pxymbc9h81x9jvgg0-gitea-1.3.2-bin/bin
patching script interpreter paths in /nix/store/0z0fic8lwxz8bx4pxymbc9h81x9jvgg0-gitea-1.3.2-bin
patching script interpreter paths in /nix/store/kfi0py592yhqhpjiq0mp6m689sfjag6p-gitea-1.3.2
patching script interpreter paths in /nix/store/2c0mawq9r6q6iffln3jgdzyb261jqn99-gitea-1.3.2-data
/nix/store/0z0fic8lwxz8bx4pxymbc9h81x9jvgg0-gitea-1.3.2-bin
There was a problem hiding this comment.
Failure for system: aarch64-linux
code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/charmap
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/japanese
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/korean
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/simplifiedchinese
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/traditionalchinese
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/unicode
code.gitea.io/gitea/vendor/gopkg.in/testfixtures.v2
builder for '/nix/store/7324824ls821s8chqsvl4rfxyxwswc0q-gitea-1.3.2.drv' failed with exit code 48
error: build of '/nix/store/7324824ls821s8chqsvl4rfxyxwswc0q-gitea-1.3.2.drv' failed
There was a problem hiding this comment.
Failure for system: x86_64-linux
code.gitea.io/gitea/vendor/github.com/PuerkitoBio/goquery
code.gitea.io/gitea/integrations
code.gitea.io/gitea/modules/test
can't load package: package code.gitea.io/gitea/scripts: build constraints exclude all Go files in /tmp/nix-build-gitea-1.3.2.drv-0/go/src/code.gitea.io/gitea/scripts
installing
/tmp/nix-build-gitea-1.3.2.drv-0/go /tmp/nix-build-gitea-1.3.2.drv-0
/nix/store/qrrs86f3w24c0y8paxzv5fxy5gyqn2r1-stdenv/setup: fork: Cannot allocate memory
/nix/store/qrrs86f3w24c0y8paxzv5fxy5gyqn2r1-stdenv/setup: line 146: wait_for: No record of process 31102
builder for ‘/nix/store/06jxl0nlh4sjiy4hhx033ma6v1smasf6-gitea-1.3.2.drv’ failed with exit code 127
error: build of ‘/nix/store/06jxl0nlh4sjiy4hhx033ma6v1smasf6-gitea-1.3.2.drv’ failed
|
builds fine, tested and nixos service runs. Didn't extensively test UI, but a curl of port 3000 gives login page. merging! Thanks for the contribution! |
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)