Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve division by zero exception #5395

Merged
merged 1 commit into from Dec 18, 2017
Merged

Improve division by zero exception #5395

merged 1 commit into from Dec 18, 2017

Conversation

sdogruyol
Copy link
Member

Working on my Crystal book, I thought the error message related to DivisionByZero exception class could be better.

  • Renamed the class to be DivisionByZeroError like the other exceptions directly inheriting from Exception as InvalidByteSequenceError, KeyError and others.
  • Changed the message to be Division by 0

This PR:

Division by 0 (DivisionByZeroError)

Before:

Division by zero (DivisionByZero)

Thank you ❤️

@RX14 RX14 added this to the Next milestone Dec 18, 2017
@RX14 RX14 merged commit bec582a into crystal-lang:master Dec 18, 2017
@RX14 RX14 modified the milestones: 0.24.1, Next Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
breaking-change kind:refactor topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdogruyol @jhass @straight-shoota @RX14