Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.bustle: build icons and metadata #32746

Merged
merged 1 commit into from Dec 17, 2017
Merged

haskellPackages.bustle: build icons and metadata #32746

merged 1 commit into from Dec 17, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 16, 2017

Motivation for this change

Tests do not build at the moment (wjt/bustle#6) and neither does hgettext (haskell-hvr/hgettext#10). While at it, I also started building icons and metadata.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar requested a review from peti December 16, 2017 21:41
@grahamc
Copy link
Member

grahamc commented Dec 17, 2017

@GrahamcOfBorg eval

@peti peti merged commit 2737fab into NixOS:master Dec 17, 2017
@jtojnar jtojnar deleted the bustle branch December 17, 2017 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @grahamc @peti @GrahamcOfBorg