Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocsigen-i18n: do not strip #32758

Merged
merged 2 commits into from Dec 21, 2017
Merged

ocsigen-i18n: do not strip #32758

merged 2 commits into from Dec 21, 2017

Conversation

FlorentBecker
Copy link
Contributor

The executables generated by ocamlc were not functional.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FlorentBecker
ocsigen-i18n: build with ocamlopt
261eedf 
The executables generated by ocamlc were not functional.
@vbgl
Copy link
Contributor

vbgl commented Dec 19, 2017

Would the problem be also solved by setting dontStrip = true;?

@FlorentBecker
Copy link
Contributor Author

I don't know, I can check.

@FlorentBecker
ocsigen-i18n: use dontStrip rather than compiling natively
48a3849 
Upstream releases a makefile which compiles to bytecode, so we should honor that.
@FlorentBecker
Copy link
Contributor Author

indeed, it can.

@FlorentBecker FlorentBecker changed the title ocsigen-i18n: build with ocamlopt ocsigen-i18n: do not strip Dec 21, 2017
@vbgl vbgl merged commit f1bbc67 into NixOS:master Dec 21, 2017
@vbgl
Copy link
Contributor

vbgl commented Dec 21, 2017

Thanks. It would be nice if the stripping phase were cautious with OCaml bytecode programs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FlorentBecker @vbgl @GrahamcOfBorg