Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio: 0.15.37 -> 0.15.40 #32759

Merged
merged 1 commit into from Dec 23, 2017
Merged

factorio: 0.15.37 -> 0.15.40 #32759

merged 1 commit into from Dec 23, 2017

Conversation

bflyblue
Copy link
Contributor

@bflyblue bflyblue commented Dec 17, 2017

stable is now 0.15.40
demo: 0.15.33 -> 0.15.36

Motivation for this change

New stable versions of factorio

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

stable is now 0.15.40
demo: 0.15.33 -> 0.15.36
@disassembler
Copy link
Member

@GrahamcOfBorg build factorio

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: Factorio: unsupported platform
(use '--show-trace' to show detailed location information)

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

error: Factorio: unsupported platform
(use '--show-trace' to show detailed location information)

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

error: Package ‘factorio-alpha-0.15.40’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/games/factorio/default.nix:90 has an unfree license (‘unfree’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@disassembler
Copy link
Member

I tried building this locally since it's nonfree but it wants a username and password. Can you confirm this builds fine on your system and check the box tested execution of all binaries and I'll merge?

@srhb
Copy link
Contributor

srhb commented Dec 23, 2017

Builds and runs for me. :)

@bflyblue
Copy link
Contributor Author

Tested and ticked the box :)

@orivej orivej merged commit 8572e0f into NixOS:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants