Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/i2pd: tunnel configuration fixes #32186

Merged
merged 1 commit into from Dec 3, 2017
Merged

nixos/i2pd: tunnel configuration fixes #32186

merged 1 commit into from Dec 3, 2017

Conversation

jbboehr
Copy link
Contributor

@jbboehr jbboehr commented Nov 30, 2017 •
edited

Motivation for this change

Tunnel configuration has no member named "host" - i2pd does but it's called "address" in the options.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jbboehr
Copy link
Contributor Author

jbboehr commented Nov 30, 2017

The inTunnels configuration is always empty because it's impossible to satisfy the condition - you cannot declare a host attribute as the validation fails.

Noob question: is it possible/is there an example somewhere on how to setup an overlay for a service.

@jbboehr
Copy link
Contributor Author

jbboehr commented Nov 30, 2017 •
edited

I'm testing it now and running into an integer coercion issue. edit: fixed

@jbboehr
Copy link
Contributor Author

jbboehr commented Dec 1, 2017

I've figured out how to test it on my system at least using disabledModules, thanks to sphalerite on IRC, and it appears to be working correctly.

@jbboehr
nixos/i2pd: tunnel config fixes
67c3f7f 
Tunnel configuration has no member named "host" - i2pd does but it's called "address" in the options. As a result, no tunnel configuration is generated.

* Fix attribute check in inTunnels
* Fix integer to string coercion in inTunnels
* Add destinationPort option for outTunnels
@jbboehr jbboehr changed the title nixos: i2pd: fix attribute check in inTunnels nixos/i2pd: tunnel configuration fixes Dec 1, 2017
@jbboehr
Copy link
Contributor Author

jbboehr commented Dec 1, 2017

Ping @joachifm

@joachifm joachifm merged commit 58e4f8a into NixOS:master Dec 3, 2017
@jbboehr
Copy link
Contributor Author

jbboehr commented Dec 3, 2017

@joachifm thanks!

@jbboehr jbboehr deleted the patch-1 branch December 3, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbboehr @joachifm @GrahamcOfBorg