amazon-image: use NTP provided by the hypervisor #32188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/set-time.html for more information. Fixes #32187
|
Hm, I hit merge before seeing #32187 (comment). So maybe we need to revert this. |
|
If I just list the standard pool addresses after the 169.254 address, will it just fall back to those if the first is unreachable? |
It'll try to reach out to all servers listed regardless and use info from all reachable servers to pick the best time. Worst case, it would add noise to servers that can't reach one or the other time source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/set-time.html for more information.
Fixes #32187
I don't feel strongly on whether to backport to 17.09. @globin @fpletz?
Motivation for this change
This allows our AWS AMI to work seamlessly with correct time even when started in a VPC with no internet connectivity.