Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty update 0.5.0 #32193

Closed
wants to merge 2 commits into from
Closed

kitty update 0.5.0 #32193

wants to merge 2 commits into from

Conversation

tex
Copy link
Contributor

@tex tex commented Nov 30, 2017

Motivation for this change

Fixes #32155

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Nov 30, 2017
View reviewed changes
pkgs/applications/misc/kitty/default.nix
@@ -1,19 +1,19 @@
{ stdenv, fetchFromGitHub, pkgs, python3Packages, glfw, libunistring, glew, fontconfig, zlib, pkgconfig, ncurses, imagemagick, makeWrapper }:
{ stdenv, fetchFromGitHub, pkgs, python3Packages, glfw, libunistring, harfbuzz, fontconfig, zlib, pkgconfig, ncurses, imagemagick, makeWrapper, xsel, libstartup_notification }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not seem to be using xsel anywhere. You will want to replace it here with the full path or add it to PATH in the installPhase.

Same for libstartup_notification, replace find_library in https://github.com/kovidgoyal/kitty/blob/8cad6ae9d6a26efcdc26f9d9338cb034a9027e32/kitty/utils.py#L240 with LoadLibrary('${libstartup_notification}/lib/libstartup-notification-1.so') or something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review!

jtojnar
jtojnar approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 30, 2017

Closed in 8bc0bf6

@jtojnar jtojnar closed this Nov 30, 2017
@jtojnar jtojnar mentioned this pull request Nov 30, 2017
Closed
@vcunat
Copy link
Member

vcunat commented Nov 30, 2017

So many CZ contributors this year :-)

@tex tex deleted the kitty branch November 30, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tex @jtojnar @vcunat @GrahamcOfBorg