Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/boot: tmpOnTmpfs -> tmpfsOnTmp #32990

Closed
wants to merge 1 commit into from

Conversation

lukateras
Copy link
Member

Motivation for this change

#17494 (comment)

I also think that would be a better name.

Things done

Ran nixos-rebuild -I nixpkgs=... switch to make sure that I would get a warning when boot.tmpOnTmpfs is used:

trace: warning: The option `boot.tmpOnTmpfs' defined in `/etc/nixos/configuration.nix' has been renamed to `boot.tmpfsOnTmp'.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 23, 2017

I think both variants makes sense grammatically but I slightly prefer the original one. Yes, tmpfs is mounted onto /tmp directory but the directory contents are actually stored on tpmfs. I interpret the tmp in the option name as the directory for which tmpfs is the underlying storage, not as the mountpoint. Also tmp on tmpfs is the term used by other distributions, see #17494 (comment).

@lukateras
Copy link
Member Author

Other distros using current name is a very good argrument, although "tmpfs on tmp" has 36 times as many search results on Google vs "tmp on tmpfs". Given that there is no consensus on which one is better, I'm closing this.

@lukateras lukateras closed this Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants