Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqPackages.contribs: recurse into the nested set #32985

Merged
merged 2 commits into from Dec 22, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Dec 22, 2017

Motivation for this change

The attribute compatibleCoqVersions is set but not used, unless a recursive filtering is used.

Therefore, there are currently a lot of broken packages (e.g., coqPackages.contribs.continuations).

The revision for containers is also fixed: released version, that builds with 8.6.

@jwiegley Thanks for contributing the whole set of contribs to nixpkgs. Going through a pull-request could have helped finding and fixing this issue before merging a lot of broken stuff to master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jwiegley
Copy link
Contributor

Thanks for the fixes @vbgl. Next time it will come in the form of a pull request.

@vbgl vbgl deleted the coq-contribs-recurse branch December 22, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants