Add CentOS 7.4 builds for 1.11-maintenance nix #1758
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a Centos 7.4 VM image, a handful of contributors have started a wider effort to get the master nix packaged for enterprise linux.
While that's a non-trivial effort and may even be fundamentally misguided given that the resulting RPM will have dependencies on other package distributions and a different ABI, in the meantime it turns out that the stable branch of nix builds on RHEL/CentOS 7.4 without any necessary modifications, aside from a minor backport of the RPM macro logic update to distinguish el6 from el7. Fortunately it was just a light touch, since eventually this will all be replaced with @abbradar's nice work cleaning up the RPM packaging.
This at least lets us get some coverage on Hydra build products for users interested in using nix in enterprise environments. I'm not sure if it's standard practice to add new releases to a maintenance branch (I see @grahamc added
aarch64
last week, but I'd imagine that's atypical). Either way this PR at least shows users that it's not hard to build a nix RPM forel7
.Builds with nixpkgs from before the dblatex update last week; as it currently stands stable nix's documentation does not build with master nixpkgs until we upgrade dblatex.