Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CentOS 7.4 builds for 1.11-maintenance nix #1758

Closed

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Dec 23, 2017

Now that we have a Centos 7.4 VM image, a handful of contributors have started a wider effort to get the master nix packaged for enterprise linux.

While that's a non-trivial effort and may even be fundamentally misguided given that the resulting RPM will have dependencies on other package distributions and a different ABI, in the meantime it turns out that the stable branch of nix builds on RHEL/CentOS 7.4 without any necessary modifications, aside from a minor backport of the RPM macro logic update to distinguish el6 from el7. Fortunately it was just a light touch, since eventually this will all be replaced with @abbradar's nice work cleaning up the RPM packaging.

This at least lets us get some coverage on Hydra build products for users interested in using nix in enterprise environments. I'm not sure if it's standard practice to add new releases to a maintenance branch (I see @grahamc added aarch64 last week, but I'd imagine that's atypical). Either way this PR at least shows users that it's not hard to build a nix RPM for el7.

Builds with nixpkgs from before the dblatex update last week; as it currently stands stable nix's documentation does not build with master nixpkgs until we upgrade dblatex.

$ nix-build release.nix -A rpm_centos74x86_64
...
[  251.473427] reboot: Power down
/nix/store/5vaa1pvbn0gy9pkqn00ff2f9wpj24ic3-nix-rpm-centos-7.4-x86_64-1.11.17pre1234_abcdef
$ tree result
result
├── nix-support
│   ├── full-name
│   └── hydra-build-products
└── rpms
    └── centos-7.4-x86_64
        ├── emacs-nix-1.11.17pre1234_abcdef-2.el7.centos.noarch.rpm
        ├── emacs-nix-el-1.11.17pre1234_abcdef-2.el7.centos.noarch.rpm
        ├── nix-1.11.17pre1234_abcdef-2.el7.centos.src.rpm
        ├── nix-1.11.17pre1234_abcdef-2.el7.centos.x86_64.rpm
        ├── nix-debuginfo-1.11.17pre1234_abcdef-2.el7.centos.x86_64.rpm
        ├── nix-devel-1.11.17pre1234_abcdef-2.el7.centos.x86_64.rpm
        └── nix-doc-1.11.17pre1234_abcdef-2.el7.centos.noarch.rpm

3 directories, 9 files

The stable branch of nix builds on RHEL/CentOS 7.4 without any necessary
modifications, aside from a minor backport of the RPM macro logic update to
distinguish el6 from el7.
@bhipple bhipple changed the title Add CentOS 7.4 builds to release.nix Add CentOS 7.4 builds for 1.11-maintenance nix Dec 23, 2017
@FRidh
Copy link
Member

FRidh commented Dec 23, 2017

We could look at backporting parts of #1141 to obtain Nix 1.11 multi-user RPM's. The RPM already includes that.

@edolstra
Copy link
Member

The dblatex issue can be avoided by cherry-picking 58e423c.

More spring cleaning.
@bhipple
Copy link
Contributor Author

bhipple commented Dec 30, 2017

There's no code with fewer bugs and less maintenance cost than no code!

Updated PR with the cherry-picked pdf manual removal commit.

@dtzWill
Copy link
Member

dtzWill commented Dec 31, 2017

FWIW the CentOS 7 image isn't available on 17.09 currently, but I think it could be backported easily if that was a problem.

@FRidh
Copy link
Member

FRidh commented Jan 11, 2018

I've been using this on one machine successfully for some time now. @dtzWill I've just pushed NixOS/nixpkgs@3007961 to 17.09

@bhipple
Copy link
Contributor Author

bhipple commented Jan 27, 2018

Anything else to be done for this PR?

@shlevy shlevy added the backlog label Apr 1, 2018
@shlevy shlevy self-assigned this Apr 1, 2018
@bhipple
Copy link
Contributor Author

bhipple commented Dec 30, 2018

While this PR is still valid, I'd imagine most users are just going to use one of the nix 2 releases instead of the nix 1.11 branch, so I'm going to close this backport.

@bhipple bhipple closed this Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants