Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a07697364174
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 94505082ee25
Choose a head ref
  • 9 commits
  • 9 files changed
  • 2 contributors

Commits on Dec 19, 2017

  1. Ensure assignable constant failure produces error

    The recent fixes ensured that the on_assign_error callback was issued, but MRI fails the whole parse in this case.
    grddev committed Dec 19, 2017
    Copy the full SHA
    7b02e5c View commit details

Commits on Dec 20, 2017

  1. Do not skip whitespace in percent literals

    I'm not sure why this was introduced, as I don't think this was ever a thing for anything beyond w/W/i/I, and those have explicit whitespace removal in their respective cases.
    grddev committed Dec 20, 2017
    Copy the full SHA
    b07e268 View commit details

Commits on Dec 21, 2017

  1. Move peekVariableName to LexingCommon

    So that Ripper can also benefit from it.
    grddev committed Dec 21, 2017

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    81b4fe6 View commit details
  2. Ensure # is included in string with invalid gvar

    The parser correctly identified that no interpolation should happen, but failed to include the hash symbol in the result.
    grddev committed Dec 21, 2017
    Copy the full SHA
    e0ad1e4 View commit details
  3. Copy the full SHA
    78291a6 View commit details

Commits on Dec 22, 2017

  1. Fix handling of invalid gvar reference in heredoc

    For both the main Ruby parser and Ripper
    grddev committed Dec 22, 2017
    Copy the full SHA
    766bfce View commit details
  2. Tweak when down next/pushback

    The logic makes more sense to me, and seems to work better with the cryptic test cases this introduces.
    grddev committed Dec 22, 2017
    Copy the full SHA
    9d8877a View commit details
  3. Copy the full SHA
    93b588b View commit details
  4. Merge pull request #4911 from grddev/parsing-fixes

    Miscellaneous parsing fixes
    enebo authored Dec 22, 2017
    Copy the full SHA
    9450508 View commit details
Loading