-
-
Notifications
You must be signed in to change notification settings - Fork 921
Comparing changes
Open a pull request
base repository: jruby/jruby
base: a07697364174
head repository: jruby/jruby
compare: 94505082ee25
- 9 commits
- 9 files changed
- 2 contributors
Commits on Dec 19, 2017
-
Ensure assignable constant failure produces error
The recent fixes ensured that the on_assign_error callback was issued, but MRI fails the whole parse in this case.
Configuration menu - View commit details
-
Copy full SHA for 7b02e5c - Browse repository at this point
Copy the full SHA 7b02e5cView commit details
Commits on Dec 20, 2017
-
Do not skip whitespace in percent literals
I'm not sure why this was introduced, as I don't think this was ever a thing for anything beyond w/W/i/I, and those have explicit whitespace removal in their respective cases.
Configuration menu - View commit details
-
Copy full SHA for b07e268 - Browse repository at this point
Copy the full SHA b07e268View commit details
Commits on Dec 21, 2017
-
Move peekVariableName to LexingCommon
So that Ripper can also benefit from it.
Configuration menu - View commit details
-
Copy full SHA for 81b4fe6 - Browse repository at this point
Copy the full SHA 81b4fe6View commit details -
Ensure # is included in string with invalid gvar
The parser correctly identified that no interpolation should happen, but failed to include the hash symbol in the result.
Configuration menu - View commit details
-
Copy full SHA for e0ad1e4 - Browse repository at this point
Copy the full SHA e0ad1e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78291a6 - Browse repository at this point
Copy the full SHA 78291a6View commit details
Commits on Dec 22, 2017
-
Fix handling of invalid gvar reference in heredoc
For both the main Ruby parser and Ripper
Configuration menu - View commit details
-
Copy full SHA for 766bfce - Browse repository at this point
Copy the full SHA 766bfceView commit details -
The logic makes more sense to me, and seems to work better with the cryptic test cases this introduces.
Configuration menu - View commit details
-
Copy full SHA for 9d8877a - Browse repository at this point
Copy the full SHA 9d8877aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93b588b - Browse repository at this point
Copy the full SHA 93b588bView commit details -
Merge pull request #4911 from grddev/parsing-fixes
Miscellaneous parsing fixes
Configuration menu - View commit details
-
Copy full SHA for 9450508 - Browse repository at this point
Copy the full SHA 9450508View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff a07697364174...94505082ee25