Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubootClearfog: add #32996

Merged
merged 2 commits into from Dec 23, 2017
Merged

ubootClearfog: add #32996

merged 2 commits into from Dec 23, 2017

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 23, 2017

Motivation for this change

This adds the ubootClearfog package, and openssl as a buildInput (as it's needed in some uboot configurations), like this one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -42,6 +42,8 @@ let
patchShebangs tools
'';

buildInputs = [ openssl ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belongs to nativeBuildInputs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

required by tools/kwbimage.c, tools/mxsimage.c and in various other
places too.
As those are tools running on the host, it's a nativeBuildInput.
@dezgeg dezgeg merged commit c7f1aa3 into NixOS:master Dec 23, 2017
@flokli flokli deleted the clearfog-pro branch December 23, 2017 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants