Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubootTools: include kwboot #32994

Merged
merged 2 commits into from Dec 23, 2017
Merged

ubootTools: include kwboot #32994

merged 2 commits into from Dec 23, 2017

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 23, 2017

Motivation for this change

This introduces extraMakeFlags, so we can then build ubootTools with additional makeFlags (primarily to include kwboot)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @dezgeg

@flokli
uboot: add extraMakeFlags option
28d1e17
@flokli
ubootTools: set CONFIG_ARCH_MVEBU=y
4ac77bd 
u-boot only builds some architecture-specific tools, if this
architecture is selected in configuration. So a 'allnoconfig' won't
include them.

As they are pretty useful however, we'd like to have them in ubootTools.
This can be accomplished by enabling CONFIG_KIRKWOOD=y and possibly
more later.
@dezgeg dezgeg merged commit 8a844db into NixOS:master Dec 23, 2017
@flokli flokli deleted the uboot-tools branch December 23, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @dezgeg