Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbpfan: improve description, resolves #32266 #32995

Merged
merged 1 commit into from Dec 23, 2017
Merged

mbpfan: improve description, resolves #32266 #32995

merged 1 commit into from Dec 23, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Dec 23, 2017 •
edited

Motivation for this change

See #32266. /cc @davidak

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 23, 2017

@GrahamcOfBorg eval

(sorry for the noise, master was broken by a merge)

@davidak
Copy link
Member

davidak commented Dec 23, 2017

@yegortimoshenko i would also put "on all MacBook/MacBook Pros (probably all Apple computers)" and "using the applesmc module" in the description. That might be keywords people search for.

See https://github.com/dgraziotin/mbpfan

@lukateras
Copy link
Member Author

I don't like copying description from upstream :-)

I've checked mbpfan source code and all it relies on is applesmc module, which is indeed present in all Macs and MacBooks. I've ended up with "mbpfan, fan controller daemon for Apple Macs and MacBooks".

@lukateras
Copy link
Member Author

I've tried nixos-rebuild with this patch and it still evaluates.

@lukateras lukateras merged commit f89bc27 into master Dec 23, 2017
@lukateras lukateras deleted the yegortimoshenko-patch-1 branch December 23, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @grahamc @davidak @GrahamcOfBorg