Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudflare-warp: init at 2017.12.1 #32998

Closed
wants to merge 1 commit into from
Closed

cloudflare-warp: init at 2017.12.1 #32998

wants to merge 1 commit into from

Conversation

lezed1
Copy link

@lezed1 lezed1 commented Dec 23, 2017

Motivation for this change

cloudflare-warp allows you to serve a website behind Cloudflare without opening any port.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lezed1
Copy link
Author

lezed1 commented Dec 23, 2017

I think the errors are only relating to it being unfree.

@grahamc
Copy link
Member

grahamc commented Dec 26, 2017

@GrahamcOfBorg eval

@lezed1
Copy link
Author

lezed1 commented Jan 5, 2018

Is there anything else I need to do for this PR?

@7c6f434c
Copy link
Member

Why is it two packages instead of the first patchelf just making a --set-interpreter?

(trying to look at PR list page 17)

@lezed1
Copy link
Author

lezed1 commented Jun 11, 2018

@7c6f434c I don't think there is a particularly good reason. I vaguely remember doing that following some guide. I'll make it a single package (and update the binary too!)

ryantm
ryantm requested changes Sep 9, 2018
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify the expression as mentioned in other comments, and fix maintainers entry to make it able to be merged.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 8, 2018 •
edited

In the meantime Warp has been renamed Argo Tunnel and it seems the client has become cloudflared

@lezed1 are you willing to refresh your PR with the new client? Or you can close this PR and craft a new one if you prefer.

@c0bw3b c0bw3b self-assigned this Oct 9, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2018

Closing for now.
@lezed1 please feel free to come up with a new PR if you want cloudflared inside NixPkgs

@c0bw3b c0bw3b closed this Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees

@c0bw3b c0bw3b

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lezed1 @grahamc @7c6f434c @c0bw3b @ryantm @GrahamcOfBorg @Janik-Haag